[GitHub] [tvm] octoJon opened a new pull request #10875: Fix an apparent bug in the [web] timer.

[GitBox <gi...@apache.org>]

octoJon opened a new pull request #10875:
URL: https://github.com/apache/tvm/pull/10875


   I've never worked in TypeScript before, so it's possible I'm wrong, but the behavior of this timer script appears to be inconsistent with the earlier(?) code in tvm/src/runtime/rpc/rpc_module.cc#L387-388.
   
   As far as I can tell, what this code is *supposed* to be doing is scaling up the number of runs measured per trial if minRepeatMs hasn't been reached. The `max` condition seems to be intended to make sure that the number of replicates run on subsequent trials is no less than 1.618 times the previous attempt's trials -- presumably as a failsafe against somehow getting stuck in a very tight loop. The version of the code in web/src/runtime.ts wouldn't actually avoid that problem, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] kparzysz-quic merged pull request #10875: Fix an apparent bug in the [web] timer.

[GitBox <gi...@apache.org>]

kparzysz-quic merged pull request #10875:
URL: https://github.com/apache/tvm/pull/10875


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org