[GitHub] [pinot] ankitsultana commented on pull request #10423: [multistage] proper support for column-level null handling

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on PR #10423:
URL: https://github.com/apache/pinot/pull/10423#issuecomment-1532436826

   My main concern is with this part:
   
   ```
   builder.add(e.getKey(), toRelDataType(e.getValue(),
             isNullSupportEnabled || e.getValue().isNullableField()));
   ```
   
   I think if users have configured "enableNullHandling" at table level, we should let column level nullability decide whether a given column is nullable or not.
   
   If enableNullHandling is not set at the table level, then we can assume that all columns are non-null (similar to V1 engine). That would essentially mean that column level nullability is not enabled so we assume everything to be non-null.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org