You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/09/14 23:46:29 UTC

[GitHub] [openwhisk-deploy-kube] yasinghcse opened a new pull request #637: Improvement in the documentation

yasinghcse opened a new pull request #637:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/637


   Adding details in the readme to easily onboard the users on Openwhisk 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] rabbah commented on pull request #637: Improvement in the documentation

Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #637:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/637#issuecomment-692418298


   Thank you @yasinghcse for the improvements.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] rabbah commented on a change in pull request #637: Improvement in the documentation

Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #637:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/637#discussion_r488339215



##########
File path: README.md
##########
@@ -366,6 +372,8 @@ launch the tests:
  -Dwhisk.auth=$WHISK_AUTH -Dwhisk.server=https://$WHISK_SERVER -Dopenwhisk.home=`pwd`
 ```
 
+**NOTE:** You to install JDK 8 in order to run these test case

Review comment:
       ```suggestion
   **NOTE:** You need to install JDK 8 in order to run these tests.
   ```

##########
File path: README.md
##########
@@ -243,11 +243,15 @@ For simplicity, in this README, we have used `owdev` as the release name and
 You can use a different name and/or namespace simply by changing the commands
 used below.
 
+**NOTE:** Clone the repository https://github.com/apache/openwhisk-deploy-kube.git and use to helm chart available under the `helm/openwhisk` folder.

Review comment:
       ```suggestion
   **NOTE:** Clone the repository https://github.com/apache/openwhisk-deploy-kube.git and use to Helm chart available under the `helm/openwhisk` folder.
   ```

##########
File path: README.md
##########
@@ -243,11 +243,15 @@ For simplicity, in this README, we have used `owdev` as the release name and
 You can use a different name and/or namespace simply by changing the commands
 used below.
 
+**NOTE:** Clone the repository https://github.com/apache/openwhisk-deploy-kube.git and use to helm chart available under the `helm/openwhisk` folder.
+
 Deployment can be done by using the following single command:
 ```shell
 helm install owdev ./helm/openwhisk -n openwhisk --create-namespace -f mycluster.yaml
 ```
 
+**NOTE:** The above command will only work for Helm v3.2.0 or higher versions. Verfiy your local helm version with command `helm version`.

Review comment:
       ```suggestion
   **NOTE:** The above command will only work for Helm v3.2.0 or higher versions. Verfiy your local Helm version with the command `helm version`.
   ```

##########
File path: README.md
##########
@@ -260,9 +264,11 @@ by simply doing `oc delete -f owdev.yaml`
 
 You can use the command `helm status owdev -n openwhisk` to get a summary
 of the various Kubernetes artifacts that make up your OpenWhisk
-deployment. Once the `install-packages` Pod is in the `Completed` state,
+deployment. Once the pod name containing the word `install-packages` is in the `Completed` state,
 your OpenWhisk deployment is ready to be used.
 
+**NOTE:** You can check the status of the pod by running the following command `kubectl get pods -n openwhisk --watch`

Review comment:
       ```suggestion
   **NOTE:** You can check the status of the pod by running the following command `kubectl get pods -n openwhisk --watch`.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] rabbah merged pull request #637: Improvement in the documentation

Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #637:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/637


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org