[GitHub] [incubator-daffodil] jadams-tresys commented on a change in pull request #281: Remove heap sized limit for parsing

[GitBox <gi...@apache.org>]

jadams-tresys commented on a change in pull request #281: Remove heap sized limit for parsing
URL: https://github.com/apache/incubator-daffodil/pull/281#discussion_r342265107
 
 

 ##########
 File path: daffodil-io/src/main/scala/org/apache/daffodil/io/InputSource.scala
 ##########
 @@ -340,6 +352,9 @@ class BucketingInputSource(inputStream: java.io.InputStream, bucketSize: Int = 1
       while (bytesStillToGet > 0) {
         val bytesToGetFromCurrentBucket = Math.min(bucketSize - byteIndex, bytesStillToGet).toInt
 
+        if (buckets(bucketIndex.toInt) == null)
 
 Review comment:
   I think my most recent commit addresses this with the added check on Pstate.isDataStreamValid, but I'm not sure I understand how this situation works where the user initiates another parse with the same data input stream, so I don't have any tests to cover this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services