You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/03/28 06:05:49 UTC
[PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
kou opened a new pull request, #45963:
URL: https://github.com/apache/arrow/pull/45963
This is based on #45962 . We should merge this after #45962 .
### Rationale for this change
We want to stop using apache.jfrog.io. See also: #40760
### What changes are included in this PR?
Upload generated docs to GitHub Release instead of apache.jfrog.io.
Our generated docs are only for publishing. We publish them to
https://arrow.apache.org/docs/ . So we don't need any migration path
for users.
### Are these changes tested?
No. I want to try this in the next release.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2766399569
Do we actually need to upload the docs somewhere? I had no idea we were doing this. Are people downloading them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2773919580
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ca311c14d131340c4716881f3722772a9abe31a0.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/39882258848) has more details. It also includes information about 31 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2764766360
> How many files will this end up being?
By this PR? Or by all related PRs such as #45962 and #45964?
This PR adds 3 files: `docs.tar.gz{,.asc,.sha512}`
All related PRs: 180:
```
3 [1 [source archive] * 3 [original + .asc + .sha512]] +
3 [1 [.mltbx] * 3 [original + .asc + .sha512]] +
126 [(1 [sdist] + 41 [wheels]) * 3 [original + .asc + .sha512])] +
45 [8 [(3 [for Linux] + 4 [for macOS] + 1 [for Windows]) * 3 [original + .asc + .sha512])] +
3 [1 [docs.tar.gz] * 3 [original + .asc + .sha512]]
```
FYI: #45470 adds more wheels.
> Having the wheels and such be part of the github release makes sense, people are expecting that if they are not used to ASF ways.
The "people" refers Python users, right? In general, Python users use PyPI not GitHub Release.
> I think artifacts would be a more appropriate storage for this and are easily manipulated using `gh`.
If we use GitHub Actions workflow artifacts, people who verify an RC need their GitHub token to download artifacts from GitHub Actions workflow artifacts.
BTW, we need to use multiple `gh` commands to download from GitHub Actions wokflow artifacts (`gh workflow list` and `gh run download`). We can use one `gh release download` command or just `curl` with GitHub Release.
> Or should we create a workflow in arrow-site that uses the released binaries to build the docs?
It's an option but it's a bit risky. Building docs in a workflow in arrow-site may be failed after a vote...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2767782144
Previously, the docs were generated after a release vote. But it sometimes failed. So, we changed to generate the docs in release process, keep it and upload it to apache/arrow-site after a release vote.
It's not for users. It's just for a stable release process.
BTW, is it strange that we use GitHub Release for artifacts for a release but not for users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2764555490
-0
How many files will this end up being? Having the wheels and such be part of the github release makes sense, people are expecting that if they are not used to ASF ways. This on the other hand only uses the release area for temporary storage, littering it with files the users are not interested in.
I think artifacts would be a more appropriate storage for this and are easily manipulated using `gh`. Or should we create a workflow in arrow-site that uses the released binaries to build the docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #45963:
URL: https://github.com/apache/arrow/pull/45963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2772432809
Oh I guess if we already have 170+ files it doesn't really matter ^^, let's test it with 20.0 I'll merge it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2770435184
> BTW, is it strange that we use GitHub Release for artifacts for a release but not for users?
Yes, I'd say it's a little unconventional. We have just been doing all kinds of funky stuff with it in crossbow^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2764331783
Rebased. I'll merge in a few days if nobody objects this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2771218147
> Yes, I'd say it's a little unconventional.
Hmm.
I want to simplify our release process. If we use limited places for artifacts, we can simplify our release process.
If we prefer GitHub Actions workflow artifacts to unconventional (but I don't think so...) GitHub Release usage, I'll re-implement this. But it'll spread artifacts to one more place.
> We have just been doing all kinds of funky stuff with it in crossbow^^
I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45961: [Release][Docs] Upload generated docs to GitHub Releases not apache.jfrog.io [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45963:
URL: https://github.com/apache/arrow/pull/45963#issuecomment-2760317133
:warning: GitHub issue #45961 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org