You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by cotedm <gi...@git.apache.org> on 2016/07/22 18:11:17 UTC

[GitHub] kafka pull request #1653: KAFKA-2932: Adjust importance level of Kafka Conne...

GitHub user cotedm opened a pull request:

    https://github.com/apache/kafka/pull/1653

    KAFKA-2932: Adjust importance level of Kafka Connect configs

    @ewencp I went down the list of connect configs and it looks like only the internal converter configs are mismarked.  It looks like the `cluster` config that is present in the current docs is already gone.  The only other values I can see arguing to change importance on are the ssl configs (marked high) but they are consistent with the producer/consumer config docs so that's at least consistent.  Everything else marked high looks either mandatory or requires consideration in a production deployment to me.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cotedm/kafka KAFKA-2932

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1653.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1653
    
----
commit c3e076a75e1e714c2585e9b976f5b746d804eaa5
Author: Dustin Cote <du...@confluent.io>
Date:   2016-07-22T18:01:39Z

    lower importance rating for internal converter settings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1653: KAFKA-2932: Adjust importance level of Kafka Conne...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/1653


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---