[directory-fortress-core] branch master updated: Size is not needed

[sm...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

smckinney pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/directory-fortress-core.git


The following commit(s) were added to refs/heads/master by this push:
     new a5f6a9d6 Size is not needed
a5f6a9d6 is described below

commit a5f6a9d6762b6ec63815908276178d7ea7f1aff5
Author: Shawn McKinney <sm...@symas.com>
AuthorDate: Tue Jul 4 09:13:38 2023 -0500

    Size is not needed
---
 README-LOAD-TESTING.md                                  |  4 +---
 .../apache/directory/fortress/core/jmeter/UserBase.java | 17 -----------------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/README-LOAD-TESTING.md b/README-LOAD-TESTING.md
index e2a440f6..c74096f4 100644
--- a/README-LOAD-TESTING.md
+++ b/README-LOAD-TESTING.md
@@ -160,7 +160,6 @@ The following may be injected into the runtime either as Java system (-D) comman
 | sleep     | Integer | all                 | True         | True             | Sleep this many milliseconds after op.                                                     | sleep=30                  | none (no sleep)        |
 | hostname  | String  | all                 | False        | True             | Useful for distributing the load in a multi-master env. Will override fortress.properties. | hostname=foo              | none                   |
 | duplicate | Integer | ftAddUser/ftDelUser | False        | True             | Duplicate operation after specified interval.                                              | duplicate=1000            | none (don't duplicate) |
-| size      | Integer | ftCheckUser         | True         | True             | Specifies batch size of users. e.g. 1000                                                   | size=1000                 | none                   |
 | ou        | String  | ftAddUser           | True         | True             | The group name used                                                                        | name=localhost-A1-1       | none                   |
 
 * The Java system properties take precedence over jmeter params.
@@ -201,11 +200,10 @@ C. Check Users:
 Will perform a createSession.  Optionally reads the entry and/or permission checks.
 
 ```bash
-mvn verify -Ploadtest -Dtype=ftCheckUser -Dqualifier=A1 -Dverify=true -Dsize=20 -Dperm=jmeterobject.oper
+mvn verify -Ploadtest -Dtype=ftCheckUser -Dqualifier=A1 -Dverify=true -Dperm=jmeterobject.oper
 ```
 
 This test performs createSession and optionally checkAccess on users.  It uses runtime arguments to define behavior:
- - size=20                  <-- defines the number of users in the test set
  - perm=jmeterobject.oper   <-- this is an optional property, will perform permission checks if set
 
 ___________________________________________________________________________________
diff --git a/src/test/java/org/apache/directory/fortress/core/jmeter/UserBase.java b/src/test/java/org/apache/directory/fortress/core/jmeter/UserBase.java
index 75b97a90..871c136c 100644
--- a/src/test/java/org/apache/directory/fortress/core/jmeter/UserBase.java
+++ b/src/test/java/org/apache/directory/fortress/core/jmeter/UserBase.java
@@ -65,8 +65,6 @@ public abstract class UserBase extends AbstractJavaSamplerClient
     protected String ou = null;
     // between tests
     protected int sleep = 0;
-    // size of test set
-    protected int size = 0;
     // used for replication tests
     protected int duplicate = 0;
 
@@ -191,15 +189,6 @@ public abstract class UserBase extends AbstractJavaSamplerClient
         {
             sleep = Integer.valueOf( szSleep );
         }
-        String szSize = System.getProperty( "size" );
-        if (StringUtils.isEmpty( szSize ))
-        {
-            szSize = samplerContext.getParameter( "size" );
-        }
-        if (!StringUtils.isEmpty( szSize ))
-        {
-            size = Integer.valueOf(szSize);
-        }
         String szDuplicate = System.getProperty( "duplicate" );
         if (!StringUtils.isEmpty( szDuplicate ))
         {
@@ -244,10 +233,4 @@ public abstract class UserBase extends AbstractJavaSamplerClient
         info( message );
         System.exit(0);
     }
-
-    protected int getRandomNumber()
-    {
-        int number = (int) ((Math.random() * (size - 1)) + 1);
-        return number;
-    }
 }