You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/03/10 07:54:23 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1326: [CELEBORN-400] Add RPC metrics for OpenStream

AngersZhuuuu opened a new pull request, #1326:
URL: https://github.com/apache/incubator-celeborn/pull/1326

   ### What changes were proposed in this pull request?
    Add RPC metrics for OpenStream
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1326: [CELEBORN-400] Add RPC metrics for OpenStream

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1326:
URL: https://github.com/apache/incubator-celeborn/pull/1326#issuecomment-1463409491

   ping @waitinfuture @FMX 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1326: [CELEBORN-400] Add RPC metrics for OpenStream

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1326:
URL: https://github.com/apache/incubator-celeborn/pull/1326#issuecomment-1463421642

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1326](https://codecov.io/gh/apache/incubator-celeborn/pull/1326?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6eeba9c) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/2d4a4f25bdf497e19a79ed98e95a781b36af5a49?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d4a4f2) will **increase** coverage by `0.05%`.
   > The diff coverage is `37.50%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1326      +/-   ##
   ============================================
   + Coverage     27.76%   27.80%   +0.05%     
   - Complexity      840      846       +6     
   ============================================
     Files           221      221              
     Lines         18450    18455       +5     
     Branches       1978     1979       +1     
   ============================================
   + Hits           5120     5130      +10     
     Misses        12974    12974              
   + Partials        356      351       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...che/celeborn/common/metrics/source/RPCSource.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL1JQQ1NvdXJjZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [.../celeborn/service/deploy/worker/FetchHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1326?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL0ZldGNoSGFuZGxlci5zY2FsYQ==) | `38.16% <75.00%> (+0.41%)` | :arrow_up: |
   
   ... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1326/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] waitinfuture merged pull request #1326: [CELEBORN-400] Add RPC metrics for OpenStream

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1326:
URL: https://github.com/apache/incubator-celeborn/pull/1326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org