You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "carryxyh (GitHub)" <gi...@apache.org> on 2018/09/29 07:14:11 UTC
[GitHub] [incubator-dubbo] carryxyh opened pull request #2584:
Optimize LeastActiveLoadBalance and add weight test case.
Optimize LeastActiveLoadBalance and add weight test case.
related pr to master:
https://github.com/apache/incubator-dubbo/pull/2172
related issue:
https://github.com/apache/incubator-dubbo/issues/2540
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2584 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2584:
Optimize LeastActiveLoadBalance and add weight test case.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2584 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2584:
Optimize LeastActiveLoadBalance and add weight test case.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=h1) Report
> Merging [#2584](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/0ac21f06974b2d8bc80ef777a31ca320ec05f81b?src=pr&el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2584 +/- ##
============================================
+ Coverage 47.41% 47.52% +0.11%
- Complexity 4291 4303 +12
============================================
Files 557 557
Lines 24433 24433
Branches 4349 4349
============================================
+ Hits 11584 11613 +29
+ Misses 11054 11023 -31
- Partials 1795 1797 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pc/cluster/loadbalance/LeastActiveLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2584/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL0xlYXN0QWN0aXZlTG9hZEJhbGFuY2UuamF2YQ==) | `88.57% <100%> (+17.14%)` | `9 <0> (+3)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2584/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `84.61% <0%> (+11.53%)` | `8% <0%> (ø)` | :arrow_down: |
| [...rpc/cluster/loadbalance/RoundRobinLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2584/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL1JvdW5kUm9iaW5Mb2FkQmFsYW5jZS5qYXZh) | `88.09% <0%> (+30.95%)` | `9% <0%> (+5%)` | :arrow_up: |
| [...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2584/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL1JhbmRvbUxvYWRCYWxhbmNlLmphdmE=) | `88.88% <0%> (+38.88%)` | `8% <0%> (+4%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=footer). Last update [0ac21f0...f860023](https://codecov.io/gh/apache/incubator-dubbo/pull/2584?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2584 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org