[GitHub] [airflow] josh-fell commented on a diff in pull request #29500: Move libjars parameter in Sqoop Hook to Hook parameter

["josh-fell (via GitHub)" <gi...@apache.org>]

josh-fell commented on code in PR #29500:
URL: https://github.com/apache/airflow/pull/29500#discussion_r1105194435


##########
airflow/providers/apache/sqoop/hooks/sqoop.py:
##########
@@ -61,14 +61,15 @@ def __init__(
         hcatalog_database: str | None = None,
         hcatalog_table: str | None = None,
         properties: dict[str, Any] | None = None,
+        libjars: str | None = None,

Review Comment:
   Maybe this idea to extend to `files` and `archives` too seeing as they are ["not typically used with Sqoop, but they are included as part of Hadoop’s internal argument-parsing system."](https://sqoop.apache.org/docs/1.4.2/SqoopUserGuide.html#_using_generic_and_specific_arguments)?



##########
airflow/providers/apache/sqoop/hooks/sqoop.py:
##########
@@ -46,6 +45,7 @@ class SqoopHook(BaseHook):
     :param verbose: Set sqoop to verbose.
     :param num_mappers: Number of map tasks to import in parallel.
     :param properties: Properties to set via the -D argument
+    :param libjars: Optional Comma separated jar files to include in the classpath.

Review Comment:
   ```suggestion
       :param libjars: Optional comma separated jar files to include in the classpath.
   ```
   Nit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org