[jira] [Comment Edited] (CONFIGURATION-817) Upgrade to JUnit 5

["Matt Juntunen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONFIGURATION-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565221#comment-17565221 ] 

Matt Juntunen edited comment on CONFIGURATION-817 at 7/12/22 2:17 AM:
----------------------------------------------------------------------

bq. How do we feel about using some more advanced JUnit 5 functionality? 

IMHO, the examples given do not add to the readability of the tests so my vote is to leave them as-is. 

bq. Is it perhaps an idea to split this ticket into two?

Sounds perfectly reasonable to me. Plus, as you mention, others will be able to use JUnit 5 sooner rather than later.


was (Author: mattjuntunen):
> How do we feel about using some more advanced JUnit 5 functionality? 

IMHO, the examples given do not add to the readability of the tests so my vote is to leave them as-is. 

> Is it perhaps an idea to split this ticket into two?

Sounds perfectly reasonable to me. Plus, as you mention, others will be able to use JUnit 5 sooner rather than later.

> Upgrade to JUnit 5
> ------------------
>
>                 Key: CONFIGURATION-817
>                 URL: https://issues.apache.org/jira/browse/CONFIGURATION-817
>             Project: Commons Configuration
>          Issue Type: Task
>          Components: Build
>            Reporter: Rob Spoor
>            Priority: Minor
>
> From https://lists.apache.org/thread/ygtkpch0s7nss4vx8xfytwsbnv7mzss9
> {quote}Matt Juntunen - Monday, 4 July 2022 04:40:43 CEST
> Re: [VOTE] Release Apache Commons Configuration 2.8.0 based on RC3
> Thanks, Bruno and Gary!
> Gary,
> I think the unit tests as a whole could use some upgrading. I'm
> picturing a conversion to JUnit 5, during which we could ensure
> compatibility with the latest JDK versions. I'm not sure what to do
> about the javadoc warnings on the generated classes. From the comments
> in the pom, this seems to have been an issue since v2.4.
> Regards,
> Matt J{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)