You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2026/02/06 13:40:08 UTC
[PR] GH-49164: [C++] Avoid invalid if() args in cmake when arrow is a subproject [arrow]
zanmato1984 opened a new pull request, #49165:
URL: https://github.com/apache/arrow/pull/49165
### Rationale for this change
Ref #49164: In subproject builds, `DefineOptions.cmake` sets `ARROW_DEFINE_OPTIONS_DEFAULT` to OFF, so `ARROW_SIMD_LEVEL` is never defined. The `if()` at `cpp/src/arrow/io/CMakeLists.txt:48` uses `${ARROW_SIMD_LEVEL}` and expands to empty, leading to invalid `if()` arguments.
### What changes are included in this PR?
Use the variable name directly (no `${}`).
### Are these changes tested?
Yes.
### Are there any user-facing changes?
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49164: [C++] Avoid invalid if() args in cmake when arrow is a subproject [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49165:
URL: https://github.com/apache/arrow/pull/49165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org