You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/17 19:54:17 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #11944: ARROW-14510: [R] [CI] ensure that docker runs don't use host-built artifacts

jonkeane commented on a change in pull request #11944:
URL: https://github.com/apache/arrow/pull/11944#discussion_r768696561



##########
File path: ci/scripts/r_valgrind.sh
##########
@@ -44,3 +49,5 @@ fi
 # https://github.com/microsoft/LightGBM/blob/fa6d356555f9ef888acf5f5e259dca958ca24f6d/.ci/test_r_package_valgrind.sh#L20-L85
 
 popd
+
+popd

Review comment:
       I added another `pushd` up above, so I added this down here to match the flow — but you're right that this shouldn't change the state or anything so is probably not needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org