You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 18:55:39 UTC
[GitHub] [airflow] kaxil opened a new pull request #12993: Add changes from 1.10.14
kaxil opened a new pull request #12993:
URL: https://github.com/apache/airflow/pull/12993
This commit adds Changelog, Updating.md and replaces 1.10.13 to 1.10.14
across the codebase
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#discussion_r540431453
##########
File path: UPDATING.md
##########
@@ -1773,6 +1766,69 @@ Now the `dag_id` will not appear repeated in the payload, and the response forma
}
```
+## Airflow 1.10.14
+
+### `[scheduler] max_threads` config has been renamed to `[scheduler] parsing_processes`
+
+From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`.
+
+This is to align the name with the actual code where the Scheduler launches the number of processes defined by
+`[scheduler] parsing_processes` to parse the DAG files.
+
+### Airflow CLI changes in line with 2.0
+
+The Airflow CLI has been organized so that related commands are grouped together as subcommands,
+which means that if you use these commands in your scripts, you have to make changes to them.
Review comment:
Suggest to change to
~_The Airflow CLI in 1.10.14 has been changed to be in line with CLI in 2.0. The 1.10.* style CLI will still work, but users will get deprecation warning messages to be reminded to upgrade their scripts. This is is part of 1.10.14's 'bridge' role._~
UPDATE: Your latest commit suffices
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#discussion_r540486984
##########
File path: CHANGELOG.txt
##########
@@ -1,3 +1,37 @@
+Airflow 1.10.14, 2020-12-10
+----------------------------
+
+Bug Fixes
+"""""""""
+
+- BugFix: Tasks with ``depends_on_past`` or ``task_concurrency`` are stuck (#12663)
+- Fix issue with empty Resources in executor_config (#12633)
+- Fix: Deprecated config ``force_log_out_after`` was not used (#12661)
+- Fix empty asctime field in JSON formatted logs (#10515)
+- [AIRFLOW-2809] Fix security issue regarding Flask SECRET_KEY (#3651)
+- [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac (#3729)
+- [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (#3738)
Review comment:
I know but we still have the all commits in Changelog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zachliu commented on a change in pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
zachliu commented on a change in pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#discussion_r540483638
##########
File path: CHANGELOG.txt
##########
@@ -1,3 +1,37 @@
+Airflow 1.10.14, 2020-12-10
+----------------------------
+
+Bug Fixes
+"""""""""
+
+- BugFix: Tasks with ``depends_on_past`` or ``task_concurrency`` are stuck (#12663)
+- Fix issue with empty Resources in executor_config (#12633)
+- Fix: Deprecated config ``force_log_out_after`` was not used (#12661)
+- Fix empty asctime field in JSON formatted logs (#10515)
+- [AIRFLOW-2809] Fix security issue regarding Flask SECRET_KEY (#3651)
+- [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac (#3729)
+- [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (#3738)
Review comment:
```suggestion
- [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (#3738)
```
https://github.com/apache/airflow/pull/3738 overrides https://github.com/apache/airflow/pull/3729 and https://github.com/apache/airflow/pull/3651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#discussion_r540431453
##########
File path: UPDATING.md
##########
@@ -1773,6 +1766,69 @@ Now the `dag_id` will not appear repeated in the payload, and the response forma
}
```
+## Airflow 1.10.14
+
+### `[scheduler] max_threads` config has been renamed to `[scheduler] parsing_processes`
+
+From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`.
+
+This is to align the name with the actual code where the Scheduler launches the number of processes defined by
+`[scheduler] parsing_processes` to parse the DAG files.
+
+### Airflow CLI changes in line with 2.0
+
+The Airflow CLI has been organized so that related commands are grouped together as subcommands,
+which means that if you use these commands in your scripts, you have to make changes to them.
Review comment:
Suggest to change to
_The Airflow CLI in 1.10.14 has been changed to be in line with CLI in 2.0. The 1.10.* style CLI will still work, but users will get deprecation warning messages to be reminded to upgrade their scripts. This is is part of 1.10.14's 'bridge' role._
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#discussion_r540427790
##########
File path: UPDATING.md
##########
@@ -1773,6 +1766,69 @@ Now the `dag_id` will not appear repeated in the payload, and the response forma
}
```
+## Airflow 1.10.14
+
+### `[scheduler] max_threads` config has been renamed to `[scheduler] parsing_processes`
+
+From Airflow 1.10.14, `max_threads` config under `[scheduler]` section has been renamed to `parsing_processes`.
+
+This is to align the name with the actual code where the Scheduler launches the number of processes defined by
+`[scheduler] parsing_processes` to parse the DAG files.
+
+### Airflow CLI changes in line with 2.0
+
+The Airflow CLI has been organized so that related commands are grouped together as subcommands,
+which means that if you use these commands in your scripts, you have to make changes to them.
Review comment:
Description here is a bit inaccurate.
I understand this part is referred from https://github.com/apache/airflow/blob/master/docs/apache-airflow/upgrading-to-2.rst but a difference here is: in 1.10.14, users will get a deprecation warning if they use the "old" commands, but they don't get a hard failure (they don't `have to make changes` in 1.10.14).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#issuecomment-742750045
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12993:
URL: https://github.com/apache/airflow/pull/12993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12993: Add changes from 1.10.14
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12993:
URL: https://github.com/apache/airflow/pull/12993#issuecomment-742779340
[The Workflow run](https://github.com/apache/airflow/actions/runs/413889132) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org