[GitHub] [pulsar] nodece commented on a diff in pull request #15634: [PIP-158][improve][client] Split client TLS transport encryption from authentication

[GitBox <gi...@apache.org>]

nodece commented on code in PR #15634:
URL: https://github.com/apache/pulsar/pull/15634#discussion_r909511411


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/NettyClientSslContextRefresher.java:
##########
@@ -46,6 +46,8 @@ public class NettyClientSslContextRefresher extends SslContextAutoRefreshBuilder
 
     public NettyClientSslContextRefresher(SslProvider sslProvider, boolean allowInsecure,
                                           String trustCertsFilePath,
+                                          String certsFilePath,
+                                          String keyFilePath,

Review Comment:
   This PR just improves the client SDK, we have the built-in client/admin in the broker/proxy, these also need this improvement. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org