[jira] [Issue Comment Deleted] (MESOS-9005) find_package_helper makes using packages REQUIRED

["Gavin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MESOS-9005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gavin updated MESOS-9005:
-------------------------
    Comment: was deleted

(was: www.rtat.net)

> find_package_helper makes using packages REQUIRED
> -------------------------------------------------
>
>                 Key: MESOS-9005
>                 URL: https://issues.apache.org/jira/browse/MESOS-9005
>             Project: Mesos
>          Issue Type: Bug
>          Components: cmake
>            Reporter: Benjamin Bannier
>            Priority: Major
>              Labels: tech-debt
>
> We currently implement a cmake function {{find_package_helper}} which, in addition to finding package artifacts, also by hand implements much of the functionality of {{find_package_handle_standard_args}}.
> One aspect not replicated is the handling of the {{REQUIRED}} flag to {{find_package}}. Instead {{find_package_helper}} always generates a hard error if an artifact cannot be found.
> It might be simpler to separate the discovery logic from the error handling logic, and delegate as much as possible to {{find_package_handle_standard_args}} so that we not only simplify our custom code, but also get the expected {{find_package}} semantics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)