[GitHub] [inlong] healchow commented on a diff in pull request #5420: [INLONG-5419][Manager] Pulsar creates model of queue error

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5420:
URL: https://github.com/apache/inlong/pull/5420#discussion_r941069539


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -152,7 +152,7 @@ public void createTopic(PulsarAdmin pulsarAdmin, PulsarTopicBean topicBean) thro
         }
 
         try {
-            if (PULSAR_QUEUE_TYPE_SERIAL.equals(topicBean.getQueueModule())) {
+            if (PULSAR_QUEUE_TYPE_SERIAL.equalsIgnoreCase(topicBean.getQueueModule())) {

Review Comment:
   It is recommended to standardize the parameters passed externally instead of making different types of case compatibility on the server side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org