You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/28 14:21:41 UTC
[GitHub] [airflow] ashb opened a new pull request #21869: rich_click 1.1.0 has a bug
ashb opened a new pull request #21869:
URL: https://github.com/apache/airflow/pull/21869
There appears to be an errant/unused import of `turtle` which needs tkinter which in turn needs libtk, which is not installed on our runners (and likely not in windows either)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21869: rich_click 1.1.0 has a bug
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21869:
URL: https://github.com/apache/airflow/pull/21869#issuecomment-1054309203
The Python distribution actually _vendors_ libtk on Windows so it somewhat ironically does not have this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21869: rich_click 1.1.0 has a bug
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21869:
URL: https://github.com/apache/airflow/pull/21869#issuecomment-1054307519
Oh maybe we don't need this, 1.1.1 has been released already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21869: rich_click 1.1.0 has a bug
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21869:
URL: https://github.com/apache/airflow/pull/21869#issuecomment-1054327934
## Version 1.1.1
Hotfix patch release to remove an accidental `from turtle import st` that crept in due to a pesky VSCode plugin.
Many thanks to [@ashb](httpsd://github.com/ashb) for spotting.
:D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #21869: rich_click 1.1.0 has a bug
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #21869:
URL: https://github.com/apache/airflow/pull/21869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21869: rich_click 1.1.0 has a bug
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21869:
URL: https://github.com/apache/airflow/pull/21869#issuecomment-1054326008
Yeah. Just noticed it too. Thanks for loking at it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org