[jira] [Closed] (FLINK-7499) double buffer release in SpillableSubpartitionView

["Nico Kruber (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nico Kruber closed FLINK-7499.
------------------------------
       Resolution: Fixed
    Fix Version/s: 1.5.0

Merged.

1.5.0: 622daa447755b984644212f56c5540253a10c149

> double buffer release in SpillableSubpartitionView
> --------------------------------------------------
>
>                 Key: FLINK-7499
>                 URL: https://issues.apache.org/jira/browse/FLINK-7499
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0, 1.1.5, 1.2.1, 1.2.2, 1.3.1, 1.4.0, 1.3.2, 1.3.3
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> {{SpillableSubpartitionView#releaseMemory()}} recycles its buffers twice: once asynchronously after the write operation and once in {{SpillableSubpartitionView#releaseMemory()}} after adding the write operation to the queue.
> 1) if {{SpillableSubpartitionView#releaseMemory()}} hits first and the buffer is recycled, the memory region may already be reused despite the pending write
> 2) If, for some reason (probably only in tests like {{SpillableSubpartitionTest#testConsumeSpillablePartitionSpilledDuringConsume()}}?), the buffer is retained and to be used in parallel somewhere else it may also not be available anymore or contain corrupt data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)