You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kamilsmuga <gi...@git.apache.org> on 2015/03/21 23:10:43 UTC
[GitHub] spark pull request: Fix links to pyspark api
GitHub user kamilsmuga opened a pull request:
https://github.com/apache/spark/pull/5120
Fix links to pyspark api
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamilsmuga/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5120
----
commit 92f03d7cc3bd9068a3705d6818eda005bd49b9a6
Author: stderr <sm...@gmail.com>
Date: 2015-03-21T22:10:04Z
Fix links to pyspark api
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by kamilsmuga <gi...@git.apache.org>.
Github user kamilsmuga commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84603519
In the middle of refactoring I realised my fork is 440+ commits behind upstream. I did merge with upstream - that's why 13240cb shows up.
Anyways, can you please verify the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-6454 [DOCS] Fix links to pyspark api
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84605560
That's fine, the commits will be squashed anyway. You generally just push new commits, and if you need to resolve a merge conflict with `master`, then use `rebase`.
Do you have an account on https://issues.apache.org/jira/browse/SPARK so I can assign the JIRA to you?
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by kamilsmuga <gi...@git.apache.org>.
Github user kamilsmuga commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84598835
Just took a look DOM elements and looks like permalinks are properly generated. E.g.
```<a class="headerlink" href="#pyspark.mllib.stat.Statistics.colStats" title="Permalink to this definition">ΒΆ</a>```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by kamilsmuga <gi...@git.apache.org>.
Github user kamilsmuga commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84596359
Is documentation generated somehow or you guys just using static markdown files?
Found 19 matches across 6 files in docs. Fixing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-6454 [DOCS] Fix links to pyspark api
Posted by kamilsmuga <gi...@git.apache.org>.
Github user kamilsmuga commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84606794
Now I have. Username: smugakamil
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84593285
Actually, there are about 15 other instances of `-class.html` URLs that appear to not work. I'm going to make a JIRA to fix them all: https://issues.apache.org/jira/browse/SPARK-6454
You can change the title here to include `SPARK-6454 [DOCS] ...` to link it. Feel free to have a look at the other occurrences and fix them too, or else I can separately tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84462144
LGTM, definitely fixes the links.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-6454 [DOCS] Fix links to pyspark api
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84461705
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Fix links to pyspark api
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5120#issuecomment-84599908
API docs are generated but the source that needs fixing here is in the markdown.
For example in http://spark.apache.org/docs/latest/mllib-data-types.html there is a link to SparseVector under the Python tab and it goes to http://spark.apache.org/docs/latest/api/python/pyspark.mllib.linalg.SparseVector-class.html which doesn't exist.
I think it's all the occurrences of links ending with `-class.html` at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org