You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ebyhr (via GitHub)" <gi...@apache.org> on 2026/04/13 05:46:49 UTC
[PR] Build: Ban toLowerCase/toUpperCase without locale [iceberg]
ebyhr opened a new pull request, #15960:
URL: https://github.com/apache/iceberg/pull/15960
I avoided [StringCaseLocaleUsage](https://errorprone.info/bugpattern/StringCaseLocaleUsage) errorprone rule because it doesn't work well with a method reference.
- Relates to #15958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ban toLowerCase/toUpperCase without locale [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #15960:
URL: https://github.com/apache/iceberg/pull/15960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ban toLowerCase/toUpperCase without locale [iceberg]
Posted by "dhruvarya-db (via GitHub)" <gi...@apache.org>.
dhruvarya-db commented on code in PR #15960:
URL: https://github.com/apache/iceberg/pull/15960#discussion_r3075683825
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -450,6 +450,11 @@
<property name="format" value="^\s*(public\s+)?(abstract\s+)?class\s+[A-Za-z0-9]*Test(\s|<)"/>
<property name="message" value="Test class names should start with 'Test' prefix, not end with 'Test' suffix. Example: 'TestNewFeature' instead of 'NewFeatureTest'"/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="id" value="BanCaseConversionWithoutLocale"/>
Review Comment:
[nit] would it make sense to add `<property name="ignoreComments" value="true"/>` here so that String::toLowerCase() usage in comments is ignored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org