You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/26 09:16:48 UTC

[GitHub] [rocketmq] jamesxuhaozhe commented on issue #1667: [ISSUE #1665] Add more unit test for Validators

jamesxuhaozhe commented on issue #1667: [ISSUE #1665] Add more unit test for Validators
URL: https://github.com/apache/rocketmq/pull/1667#issuecomment-569020476
 
 
   > @jamesxuhaozhe the Travis failed because the coverage decreased, you can ignore this temporarily, or add more unit tests to improve coverage.
   
   Thank you. However, I am still confused. Because if you take a look at the code change I made in this pr. The change did nothing but adding more unit tests. Ideally, the test coverage should increase a little bit. Let me know how should I fix this and if I am missing anything. Thanks a lot!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services