Re: Review Request 18492: HIVE-6473: Allow writing HFiles via HBaseStorageHandler table

[nick dimiduk <nd...@gmail.com>]

> On March 7, 2014, 9:01 p.m., Swarnim Kulkarni wrote:
> > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java, line 351
> > <https://reviews.apache.org/r/18492/diff/1/?file=503857#file503857line351>
> >
> >     Do we have bugs logged for this or it would be covered in future revisions on the same patch?

My intention is to address this in a future patch. Nothing filed as of yet. Let me refresh my memory here and log them. Do you want this patch to refer to those issue numbers?


- nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/#review36574
-----------------------------------------------------------


On Feb. 26, 2014, 12:07 a.m., nick dimiduk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18492/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 12:07 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6473
>     https://issues.apache.org/jira/browse/HIVE-6473
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> From the JIRA:
> 
> Generating HFiles for bulkload into HBase could be more convenient. Right now we require the user to register a new table with the appropriate output format. This patch allows the exact same functionality, but through an existing table managed by the HBaseStorageHandler.
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 8cd594b 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java 6d383b5 
>   hbase-handler/src/test/queries/negative/generatehfiles_require_family_path.q PRE-CREATION 
>   hbase-handler/src/test/queries/positive/hbase_bulk.m f8bb47d 
>   hbase-handler/src/test/queries/positive/hbase_bulk.q PRE-CREATION 
>   hbase-handler/src/test/queries/positive/hbase_handler_bulk.q PRE-CREATION 
>   hbase-handler/src/test/results/negative/generatehfiles_require_family_path.q.out PRE-CREATION 
>   hbase-handler/src/test/results/positive/hbase_handler_bulk.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18492/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nick dimiduk
> 
>