[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3763: Oauth authentication rebase

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3763: Oauth authentication rebase
URL: https://github.com/apache/trafficcontrol/pull/3763#discussion_r308809629
 
 

 ##########
 File path: traffic_portal/app/src/traffic_portal_properties.json
 ##########
 @@ -201,6 +201,16 @@
           "url": "http://trafficcontrol.apache.org/"
         }
       ]
+    },
+    "oAuth": {
+      "_comment": "Opt-in OAuth properties for SSO login. See http://traffic-control-cdn.readthedocs.io/en/release-4.0.0/admin/quick_howto/oauth_login.html for more details. redirectUriParameterOverride defaults to redirect_uri if left blank.",
+      "enabled": false,
+      "oAuthUrl": "https://oauthProvider.example.com/auth",
+      "oAuthTokenQueryParam": "example_token_key",
+      "redirectUriParameterOverride": "example_redirect_url_key",
+      "clientId": "exampleClient",
+      "oAuthCodeTokenUrl": "https://oauthProvider.example.com/auth/token",
+      "clientSecret": "AbCd123"
 
 Review comment:
   I actually think that only TO needs to know the client_secret, so you could just turn `whitelisted_oauth_urls` from an array into a map of the URLs to their associated client_secret. Then some parsing logic would need to change, and just modify how it's accessed in the route handler and you're done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services