You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cambyzju (via GitHub)" <gi...@apache.org> on 2024/03/05 06:29:16 UTC
[PR] [fix](cast) fix wrong result while cast string to float [doris]
cambyzju opened a new pull request, #31781:
URL: https://github.com/apache/doris/pull/31781
## Proposed changes
Issue Number: close https://github.com/apache/doris/issues/31518
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978135929
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978066574
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978190776
<details>
<summary>ClickBench: <b>Total hot run time: 30.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 164945d24157ba7ecfb53ccc1e558cf1c99695f0, data reload: false
query1 0.04 0.03 0.03
query2 0.06 0.02 0.02
query3 0.24 0.06 0.06
query4 1.65 0.10 0.10
query5 0.49 0.48 0.49
query6 1.29 0.66 0.67
query7 0.02 0.02 0.01
query8 0.04 0.02 0.03
query9 0.55 0.52 0.51
query10 0.56 0.57 0.57
query11 0.13 0.10 0.10
query12 0.12 0.10 0.10
query13 0.58 0.59 0.56
query14 0.75 0.74 0.75
query15 0.81 0.81 0.80
query16 0.39 0.37 0.37
query17 1.05 0.98 0.99
query18 0.27 0.26 0.27
query19 1.83 1.70 1.71
query20 0.01 0.02 0.01
query21 15.41 0.61 0.62
query22 3.95 3.51 1.67
query23 17.38 1.09 1.03
query24 2.19 0.22 0.49
query25 0.25 0.05 0.04
query26 0.19 0.13 0.13
query27 0.03 0.03 0.03
query28 12.41 0.84 0.82
query29 12.52 3.22 3.68
query30 0.63 0.59 0.59
query31 2.80 0.34 0.34
query32 3.40 0.44 0.44
query33 2.93 2.94 2.93
query34 15.47 4.31 4.30
query35 4.28 4.31 4.33
query36 1.09 1.02 1.03
query37 0.06 0.05 0.05
query38 0.05 0.03 0.03
query39 0.02 0.02 0.02
query40 0.16 0.13 0.14
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.02 0.03
Total cold run time: 106.24 s
Total hot run time: 30.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978164699
<details>
<summary>TPC-H: <b>Total hot run time: 38163 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 164945d24157ba7ecfb53ccc1e558cf1c99695f0, data reload: false
------ Round 1 ----------------------------------
q1 17925 4149 4161 4149
q2 2665 154 149 149
q3 11259 1029 980 980
q4 4972 968 968 968
q5 7844 2939 3013 2939
q6 180 124 132 124
q7 1315 818 814 814
q8 9486 2040 2050 2040
q9 7386 6438 6427 6427
q10 8237 2586 2551 2551
q11 421 219 220 219
q12 744 328 325 325
q13 17957 2902 2915 2902
q14 278 254 259 254
q15 502 461 449 449
q16 498 396 404 396
q17 943 874 823 823
q18 6697 5913 6068 5913
q19 1581 1542 1510 1510
q20 550 278 283 278
q21 7541 3715 3657 3657
q22 801 320 296 296
Total cold run time: 109782 ms
Total hot run time: 38163 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4008 3997 4006 3997
q2 316 232 238 232
q3 2943 2936 2898 2898
q4 1858 1828 1777 1777
q5 5238 5237 5241 5237
q6 201 116 116 116
q7 2253 1825 1845 1825
q8 3191 3241 3292 3241
q9 8521 8539 8543 8539
q10 6132 3720 3687 3687
q11 529 435 454 435
q12 697 568 530 530
q13 15503 2786 2771 2771
q14 282 266 246 246
q15 482 438 440 438
q16 456 410 423 410
q17 1687 1684 1658 1658
q18 7771 7544 7277 7277
q19 1605 1604 1602 1602
q20 1941 1706 1738 1706
q21 4923 4830 4883 4830
q22 542 484 495 484
Total cold run time: 71079 ms
Total hot run time: 53936 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978195743
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 164945d24157ba7ecfb53ccc1e558cf1c99695f0 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.2 seconds inserted 10000000 Rows, about 549K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978051006
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978182056
<details>
<summary>TPC-DS: <b>Total hot run time: 177768 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 164945d24157ba7ecfb53ccc1e558cf1c99695f0, data reload: false
query1 915 356 336 336
query2 7334 2188 2039 2039
query3 6702 216 212 212
query4 25020 21145 21205 21145
query5 4337 447 447 447
query6 280 188 189 188
query7 4636 333 299 299
query8 253 178 169 169
query9 8402 2202 2197 2197
query10 433 230 226 226
query11 15169 14296 14419 14296
query12 130 90 84 84
query13 1632 437 434 434
query14 8958 7370 7077 7077
query15 228 197 201 197
query16 7239 266 282 266
query17 961 613 573 573
query18 1930 290 286 286
query19 208 169 165 165
query20 95 94 95 94
query21 200 133 126 126
query22 4584 4486 4471 4471
query23 31844 30780 30917 30780
query24 12043 3029 3091 3029
query25 704 372 374 372
query26 1902 161 172 161
query27 2962 357 364 357
query28 6690 1802 1817 1802
query29 1285 628 591 591
query30 315 145 149 145
query31 934 740 745 740
query32 100 58 61 58
query33 749 253 244 244
query34 1021 458 463 458
query35 910 817 793 793
query36 951 821 805 805
query37 272 71 67 67
query38 3214 3092 3110 3092
query39 1403 1397 1366 1366
query40 297 116 113 113
query41 58 50 55 50
query42 106 101 103 101
query43 435 401 397 397
query44 1076 715 709 709
query45 202 192 199 192
query46 1056 792 762 762
query47 1632 1543 1555 1543
query48 415 369 337 337
query49 1189 330 324 324
query50 799 369 368 368
query51 6761 6546 6594 6546
query52 105 102 98 98
query53 346 284 285 284
query54 314 229 238 229
query55 86 86 85 85
query56 236 284 214 214
query57 1077 993 1002 993
query58 237 209 229 209
query59 2414 2283 2217 2217
query60 292 274 264 264
query61 117 111 112 111
query62 636 409 417 409
query63 308 287 289 287
query64 6360 3025 3172 3025
query65 3043 3008 2994 2994
query66 1470 338 336 336
query67 15115 14564 14396 14396
query68 9670 575 582 575
query69 620 393 388 388
query70 1275 1135 1051 1051
query71 570 279 287 279
query72 8746 2783 2619 2619
query73 1019 326 333 326
query74 7154 6905 6764 6764
query75 5022 2642 2660 2642
query76 6332 1125 1188 1125
query77 903 260 268 260
query78 10474 9554 9548 9548
query79 12241 526 523 523
query80 1254 385 380 380
query81 484 208 203 203
query82 667 89 88 88
query83 199 154 147 147
query84 283 80 80 80
query85 1470 336 324 324
query86 429 309 316 309
query87 3412 3195 3223 3195
query88 3709 2285 2286 2285
query89 521 364 361 361
query90 2109 171 186 171
query91 160 129 144 129
query92 60 51 51 51
query93 6562 535 522 522
query94 1325 186 184 184
query95 444 348 343 343
query96 610 260 259 259
query97 3970 3924 3894 3894
query98 222 218 208 208
query99 1225 774 755 755
Total cold run time: 306268 ms
Total hot run time: 177768 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978473229
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978066543
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on PR #31781:
URL: https://github.com/apache/doris/pull/31781#issuecomment-1978136738
update regression test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cast) fix wrong result while cast string to float [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 merged PR #31781:
URL: https://github.com/apache/doris/pull/31781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org