You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by zalun <gi...@git.apache.org> on 2014/10/08 09:50:23 UTC

[GitHub] cordova-plugin-globalization pull request: CB-7733 Errors in weekd...

GitHub user zalun opened a pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/27

    CB-7733 Errors in weekdays fixed

    * getDateNames should return (Sun - Sat) in all locales
    * getFirstDayOfWeek should return 1 for Sunday and 2 for Monday
    * bunch of jsHint fixes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zalun/cordova-plugin-globalization fix_dateNames_and_firstDay

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-globalization/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit e8baaaa8db58973c74ab44397a5c7e85ca8967dc
Author: Piotr Zalewa <pi...@zalewa.info>
Date:   2014-10-08T07:45:41Z

    Errors in weekdays fixed
    * getDateNames should return (Sun - Sat) in all locales
    * getFirstDayOfWeek should return 1 for Sunday and 2 for Monday
    * bunch of jsHint fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-globalization pull request: CB-7733 Errors in weekd...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-globalization/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-globalization pull request: CB-7733 Errors in weekd...

Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:

    https://github.com/apache/cordova-plugin-globalization/pull/27#issuecomment-58387188
  
    Looks good, r+.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org