[GitHub] [spark] uncleGen commented on a change in pull request #28391: [SPARK-31593][SS] Remove unnecessary streaming query progress update

[GitBox <gi...@apache.org>]

uncleGen commented on a change in pull request #28391:
URL: https://github.com/apache/spark/pull/28391#discussion_r416492827



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
##########
@@ -201,7 +201,7 @@ trait ProgressReporter extends Logging {
 
     if (hasExecuted) {
       // Reset noDataEventTimestamp if we processed any data
-      lastNoExecutionProgressEventTime = Long.MinValue
+      lastNoExecutionProgressEventTime = triggerClock.getTimeMillis()

Review comment:
       When reset `"lastNoExecutionProgressEventTime =Long.MinValue"`, it will make `"now - noDataProgressEventInterval >= lastNoExecutionProgressEventTime"` always `true` when there is no new data. Then progress reporter will report an `empty` progress.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org