[jira] [Comment Edited] (DRILL-5703) Add Syntax Highlighting & Autocompletion to Query Form

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113730#comment-16113730 ] 

Julian Hyde edited comment on DRILL-5703 at 8/4/17 12:16 AM:
-------------------------------------------------------------

Actually, I'm not sure that you need to rebase. I think you need to create a branch that just contains the fix to this one issue, and base your pull request on that, not your master branch. If there are multiple commits that are all required to fix the issue, squash them before you create the pull request. Interactive rebase, e.g. {{git rebase -i origin/master}} is a good way to squash commits (and other things like re-ordering commits).


was (Author: julianhyde):
Actually, I'm not sure that you need to rebase. I think you need to create a branch that just contains the fix to this one issue, and base your pull request on that, not your master branch. If there are multiple commits that are all required to fix the issue, squash them before you create the pull request. Interactive rebase, e.g. `git rebase -i origin/master` is a good way to squash commits (and other things like re-ordering commits).

> Add Syntax Highlighting & Autocompletion to Query Form
> ------------------------------------------------------
>
>                 Key: DRILL-5703
>                 URL: https://issues.apache.org/jira/browse/DRILL-5703
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.11.0
>            Reporter: Charles Givre
>
> The UI could really benefit from having syntax highlighting and autocompletion in the query window as well as the form to update storage plugins.  This PR adds that capability to the query form using the Ace code editor (https://ace.c9.io). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)