You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by an...@apache.org on 2016/03/11 08:46:43 UTC
ios commit: CB-10773 Update path delimiters in tests
Repository: cordova-ios
Updated Branches:
refs/heads/master 000a61e60 -> d11990652
CB-10773 Update path delimiters in tests
Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/d1199065
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/d1199065
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/d1199065
Branch: refs/heads/master
Commit: d1199065289c37bbaee91dceca84f78ff73b064e
Parents: 000a61e
Author: Vladimir Kotikov <v-...@microsoft.com>
Authored: Fri Mar 11 10:46:17 2016 +0300
Committer: Vladimir Kotikov <v-...@microsoft.com>
Committed: Fri Mar 11 10:46:17 2016 +0300
----------------------------------------------------------------------
tests/spec/unit/Plugman/pluginHandler.spec.js | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/d1199065/tests/spec/unit/Plugman/pluginHandler.spec.js
----------------------------------------------------------------------
diff --git a/tests/spec/unit/Plugman/pluginHandler.spec.js b/tests/spec/unit/Plugman/pluginHandler.spec.js
index d093970..d5b30d4 100644
--- a/tests/spec/unit/Plugman/pluginHandler.spec.js
+++ b/tests/spec/unit/Plugman/pluginHandler.spec.js
@@ -230,7 +230,7 @@ describe('ios plugin handler', function() {
var frameworks = copyArray(valid_custom_frameworks);
install(frameworks[0], dummyPluginInfo, dummyProject);
expect(dummyProject.xcode.addFramework)
- .toHaveBeenCalledWith(path.normalize('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'), {customFramework:true});
+ .toHaveBeenCalledWith('SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework', {customFramework:true});
});
// TODO: Add more tests to cover the cases:
@@ -384,11 +384,12 @@ describe('ios plugin handler', function() {
spyOn(dummyProject.xcode, 'removeFramework');
});
+ var frameworkPath = path.join(temp, 'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework').replace(/\\/g, '/');
+
it('should call into xcodeproj\'s removeFramework', function(){
var frameworks = copyArray(valid_custom_frameworks);
uninstall(frameworks[0], dummyPluginInfo, dummyProject);
- expect(dummyProject.xcode.removeFramework)
- .toHaveBeenCalledWith(path.join(temp, 'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'), {customFramework:true});
+ expect(dummyProject.xcode.removeFramework).toHaveBeenCalledWith(frameworkPath, {customFramework:true});
});
// TODO: Add more tests to cover the cases:
@@ -400,7 +401,7 @@ describe('ios plugin handler', function() {
var frameworks = copyArray(valid_custom_frameworks);
var spy = spyOn(shell, 'rm');
uninstall(frameworks[0], dummyPluginInfo, dummyProject);
- expect(spy).toHaveBeenCalledWith('-rf', path.join(temp, 'SampleApp/Plugins/org.test.plugins.dummyplugin/Custom.framework'));
+ expect(spy).toHaveBeenCalledWith('-rf', frameworkPath);
});
});
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org