You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2016/09/19 06:34:28 UTC
[1/2] incubator-carbondata git commit: Changed StringBuffer to
StringBuilder
Repository: incubator-carbondata
Updated Branches:
refs/heads/master a37c5b97d -> b81cf66a0
Changed StringBuffer to StringBuilder
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/83f1ceec
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/83f1ceec
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/83f1ceec
Branch: refs/heads/master
Commit: 83f1ceecbc6788fded3bbddba2bfeeca51aea2b3
Parents: a37c5b9
Author: vinodkc <vi...@gmail.com>
Authored: Sun Sep 18 17:48:44 2016 +0530
Committer: jackylk <ja...@huawei.com>
Committed: Sun Sep 18 23:32:17 2016 -0700
----------------------------------------------------------------------
.../common/logging/impl/ExtendedRollingFileAppender.java | 2 +-
.../common/logging/impl/StandardLogService.java | 4 ++--
.../carbondata/processing/csvreaderstep/CsvInputMeta.java | 2 +-
.../carbondata/processing/mdkeygen/MDKeyGenStepMeta.java | 2 +-
.../processing/merger/step/CarbonSliceMergerStepMeta.java | 2 +-
.../sortandgroupby/sortdatastep/SortKeyStepMeta.java | 2 +-
.../csvbased/CarbonCSVBasedSeqGenMeta.java | 2 +-
.../carbondata/processing/util/CarbonSchemaParser.java | 10 +++++-----
8 files changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/common/src/main/java/org/apache/carbondata/common/logging/impl/ExtendedRollingFileAppender.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/carbondata/common/logging/impl/ExtendedRollingFileAppender.java b/common/src/main/java/org/apache/carbondata/common/logging/impl/ExtendedRollingFileAppender.java
index 85f5ff9..c4aaf9f 100644
--- a/common/src/main/java/org/apache/carbondata/common/logging/impl/ExtendedRollingFileAppender.java
+++ b/common/src/main/java/org/apache/carbondata/common/logging/impl/ExtendedRollingFileAppender.java
@@ -145,7 +145,7 @@ public class ExtendedRollingFileAppender extends RollingFileAppender {
if (maxBackupIndex > 0) {
DateFormat dateFormat = new SimpleDateFormat(DATE_FORMAT_FOR_TRANSFER);
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
String extension = "";
if (fileName.contains(".")) {
extension = fileName.substring(fileName.lastIndexOf("."));
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/common/src/main/java/org/apache/carbondata/common/logging/impl/StandardLogService.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/carbondata/common/logging/impl/StandardLogService.java b/common/src/main/java/org/apache/carbondata/common/logging/impl/StandardLogService.java
index 1ad71db..8684e28 100644
--- a/common/src/main/java/org/apache/carbondata/common/logging/impl/StandardLogService.java
+++ b/common/src/main/java/org/apache/carbondata/common/logging/impl/StandardLogService.java
@@ -130,7 +130,7 @@ public final class StandardLogService implements LogService {
}
public static void setThreadName(String partitionID, String queryID) {
- StringBuffer b = new StringBuffer(PARTITION_ID);
+ StringBuilder b = new StringBuilder(PARTITION_ID);
b.append(partitionID);
if (null != queryID) {
b.append(";queryID:");
@@ -190,7 +190,7 @@ public final class StandardLogService implements LogService {
if (StandardLogService.doLog) {
try {
//Append the partition id and query id if exist
- StringBuffer buff = new StringBuffer(Thread.currentThread().getName());
+ StringBuilder buff = new StringBuilder(Thread.currentThread().getName());
buff.append(" ");
buff.append(message);
message = buff.toString();
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java b/processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java
index c5b801a..3e2b621 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInputMeta.java
@@ -202,7 +202,7 @@ public class CsvInputMeta extends BaseStepMeta
}
public String getXML() {
- StringBuffer retval = new StringBuffer(500);
+ StringBuilder retval = new StringBuilder(500);
retval.append(" ").append(XMLHandler.addTagValue(getXmlCode("FILENAME"), filename));
retval.append(" ")
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/mdkeygen/MDKeyGenStepMeta.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/mdkeygen/MDKeyGenStepMeta.java b/processing/src/main/java/org/apache/carbondata/processing/mdkeygen/MDKeyGenStepMeta.java
index f28950b..a2f0c59 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/mdkeygen/MDKeyGenStepMeta.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/mdkeygen/MDKeyGenStepMeta.java
@@ -162,7 +162,7 @@ public class MDKeyGenStepMeta extends BaseStepMeta implements StepMetaInterface
}
public String getXML() {
- StringBuffer retval = new StringBuffer(150);
+ StringBuilder retval = new StringBuilder(150);
retval.append(" ").append(XMLHandler.addTagValue("TableName", tableName));
retval.append(" ").append(XMLHandler.addTagValue("AggregateLevels", aggregateLevels));
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/merger/step/CarbonSliceMergerStepMeta.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/merger/step/CarbonSliceMergerStepMeta.java b/processing/src/main/java/org/apache/carbondata/processing/merger/step/CarbonSliceMergerStepMeta.java
index 1d712ec..d98d40a 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/merger/step/CarbonSliceMergerStepMeta.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/merger/step/CarbonSliceMergerStepMeta.java
@@ -150,7 +150,7 @@ public class CarbonSliceMergerStepMeta extends BaseStepMeta
* @throws KettleException in case there is a conversion or XML encoding error
*/
public String getXML() {
- StringBuffer retval = new StringBuffer(150);
+ StringBuilder retval = new StringBuilder(150);
retval.append(" ").append(XMLHandler.addTagValue("TableName", tabelName));
retval.append(" ").append(XMLHandler.addTagValue("MDKeySize", mdkeySize));
retval.append(" ").append(XMLHandler.addTagValue("Measurecount", measureCount));
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdatastep/SortKeyStepMeta.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdatastep/SortKeyStepMeta.java b/processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdatastep/SortKeyStepMeta.java
index 9416134..9f152fd 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdatastep/SortKeyStepMeta.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdatastep/SortKeyStepMeta.java
@@ -145,7 +145,7 @@ public class SortKeyStepMeta extends BaseStepMeta implements StepMetaInterface {
* @throws KettleException in case there is a conversion or XML encoding error
*/
public String getXML() {
- StringBuffer retval = new StringBuffer(150);
+ StringBuilder retval = new StringBuilder(150);
retval.append(" ").append(XMLHandler.addTagValue("TableName", this.tabelName));
retval.append(" ").append(XMLHandler.addTagValue("factDimLensString", factDimLensString));
retval.append(" ").append(XMLHandler.addTagValue("outputRowSize", this.outputRowSize));
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java b/processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java
index f4366eb..c896acf 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenMeta.java
@@ -659,7 +659,7 @@ public class CarbonCSVBasedSeqGenMeta extends BaseStepMeta implements StepMetaIn
}
public String getXML() throws KettleValueException {
- StringBuffer retval = new StringBuffer(150);
+ StringBuilder retval = new StringBuilder(150);
retval.append(" ").append(XMLHandler.addTagValue("carbonProps", carbonProps));
retval.append(" ").append(XMLHandler.addTagValue("dim", carbondim));
retval.append(" ").append(XMLHandler.addTagValue("msr", carbonmsr));
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/83f1ceec/processing/src/main/java/org/apache/carbondata/processing/util/CarbonSchemaParser.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonSchemaParser.java b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonSchemaParser.java
index 846ce2b..6ff63e9 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonSchemaParser.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonSchemaParser.java
@@ -578,7 +578,7 @@ public final class CarbonSchemaParser {
* @return
*/
public static String getColumnGroups(List<CarbonDimension> dimensions) {
- StringBuffer columnGroups = new StringBuffer();
+ StringBuilder columnGroups = new StringBuilder();
for (int i = 0; i < dimensions.size(); i++) {
CarbonDimension dimension = dimensions.get(i);
//assuming complex dimensions will always be atlast
@@ -648,7 +648,7 @@ public final class CarbonSchemaParser {
public static String getTableNameString(String factTableName, List<CarbonDimension> dimensions,
CarbonDataLoadSchema carbonDataLoadSchema) {
- StringBuffer stringBuffer = new StringBuffer();
+ StringBuilder stringBuffer = new StringBuilder();
for (CarbonDimension cDimension : dimensions) {
String tableName = extractDimensionTableName(cDimension.getColName(), carbonDataLoadSchema);
@@ -674,7 +674,7 @@ public final class CarbonSchemaParser {
* @return
*/
public static String getColumnIdString(List<CarbonDimension> dimensions) {
- StringBuffer stringBuffer = new StringBuffer();
+ StringBuilder stringBuffer = new StringBuilder();
for (CarbonDimension cDimension : dimensions) {
if (!cDimension.hasEncoding(Encoding.DICTIONARY)) {
continue;
@@ -741,7 +741,7 @@ public final class CarbonSchemaParser {
*/
public static String getHeirAndKeySizeMapForFact(List<CarbonDimension> dimensions,
CarbonDataLoadSchema carbonDataLoadSchema) {
- StringBuffer stringBuffer = new StringBuffer();
+ StringBuilder stringBuffer = new StringBuilder();
String heirName = null;
int[] dims = null;
int keySizeInBytes = 0;
@@ -895,7 +895,7 @@ public final class CarbonSchemaParser {
*/
public static String getPrimaryKeyString(List<CarbonDimension> dimensions,
CarbonDataLoadSchema carbonDataLoadSchema) {
- StringBuffer primaryKeyStringbuffer = new StringBuffer();
+ StringBuilder primaryKeyStringbuffer = new StringBuilder();
for (CarbonDimension cDimension : dimensions) {
String dimTableName =
extractDimensionTableName(cDimension.getColName(), carbonDataLoadSchema);
[2/2] incubator-carbondata git commit: [CARBONDATA-256]Changed
StringBuffer to StringBuilder This closes #173
Posted by ja...@apache.org.
[CARBONDATA-256]Changed StringBuffer to StringBuilder This closes #173
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/b81cf66a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/b81cf66a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/b81cf66a
Branch: refs/heads/master
Commit: b81cf66a03892830f97dfac32f21c8a8878f9660
Parents: a37c5b9 83f1cee
Author: jackylk <ja...@huawei.com>
Authored: Sun Sep 18 23:33:59 2016 -0700
Committer: jackylk <ja...@huawei.com>
Committed: Sun Sep 18 23:33:59 2016 -0700
----------------------------------------------------------------------
.../common/logging/impl/ExtendedRollingFileAppender.java | 2 +-
.../common/logging/impl/StandardLogService.java | 4 ++--
.../carbondata/processing/csvreaderstep/CsvInputMeta.java | 2 +-
.../carbondata/processing/mdkeygen/MDKeyGenStepMeta.java | 2 +-
.../processing/merger/step/CarbonSliceMergerStepMeta.java | 2 +-
.../sortandgroupby/sortdatastep/SortKeyStepMeta.java | 2 +-
.../csvbased/CarbonCSVBasedSeqGenMeta.java | 2 +-
.../carbondata/processing/util/CarbonSchemaParser.java | 10 +++++-----
8 files changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------