[jira] Commented: (HARMONY-158) Two JSE 5 methods are not implemented in java.util.zip.Deflator

["Paulex Yang (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-158?page=comments#action_12373053 ] 

Paulex Yang commented on HARMONY-158:
-------------------------------------

The codes look fine, thank you, George. 

And thank you special for your detailed observation and comments, my comments below:

>> 1) The native source patch code for this issue also made updates to the
.....
Yes, the two patches are relevant, sorry for that, seems the two JIRA should be merged as one, because they need to modify same native files. I shall try to be more considerate later.

>>2) The patch to java/util/zip/Inflater.java does not update the signature of
......
Yes, you are right again. It's my fault on this.

>>3) I have a gut feeling that there could be more test code for these changes.
......
I didn't include them because in fact the new methods are only extended version of some original methods, like getTotalIn(), etc, so the behavior should be same except when the total bytes are larger than Integer.MAX_VALUE, but IMHO this case is hard to test(we may need a huge zip file...). But you are right that it still needs more test.

4) The Javadoc comments for the new methods (e.g. getBytesRead) don't contain much explanation. What do you think ?
......
Because of the same reason above,  the Java doc is short, but I guess I should more explicitly declare the relationship between these new methods and the old ones(currently it is just implied by @see)

I'm willing to create another patch to improve the points above. Your comments?

> Two JSE 5 methods are not implemented in java.util.zip.Deflator
> ---------------------------------------------------------------
>
>          Key: HARMONY-158
>          URL: http://issues.apache.org/jira/browse/HARMONY-158
>      Project: Harmony
>         Type: Bug

>     Reporter: Paulex Yang
>     Assignee: George Harley
>  Attachments: 158-native-patch.txt, java.util.zip.Deflater.patch, java.util.zip.DeflaterTests.patch
>
> Two methods:
> java/util/zip/Deflater public getBytesRead()J
> java/util/zip/Deflater public getBytesWritten()J 
> are introduced by JSE 5, but they are not been implemented by Harmony yet. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira