You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "metatype (GitHub)" <gi...@apache.org> on 2018/11/05 21:07:39 UTC
[GitHub] [geode] metatype opened pull request #2784: Fix bugs
identified by static analysis
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
[ Full content available at: https://github.com/apache/geode/pull/2784 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on issue #2784: Fix bugs
identified by static analysis
Posted by "metatype (GitHub)" <gi...@apache.org>.
Removed a few changes in deference to other PR's in process.
[ Full content available at: https://github.com/apache/geode/pull/2784 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2784:
Fix bugs identified by static analysis
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
can "cq.getFilterID()" be null?
[ Full content available at: https://github.com/apache/geode/pull/2784 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #2784:
Fix bugs identified by static analysis
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
should you check if index is null?
[ Full content available at: https://github.com/apache/geode/pull/2784 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype closed pull request #2784: Fix bugs
identified by static analysis
Posted by "metatype (GitHub)" <gi...@apache.org>.
[ pull request closed by metatype ]
[ Full content available at: https://github.com/apache/geode/pull/2784 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org