You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "deshanxiao (via GitHub)" <gi...@apache.org> on 2023/02/28 07:41:41 UTC

[GitHub] [orc] deshanxiao opened a new pull request, #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

deshanxiao opened a new pull request, #1421:
URL: https://github.com/apache/orc/pull/1421

   ### What changes were proposed in this pull request?
   This PR aims to add slf4j-impl to avoid warning message in example module.
   
   ### Why are the changes needed?
   When we run orc java examples, the following error will show in output:
   ```
   java -cp ./examples/target/orc-examples-1.9.0-SNAPSHOT-uber.jar org.apache.orc.examples.CoreWriter
   
   SLF4J: No SLF4J providers were found.
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
   log4j:WARN No appenders could be found for logger (org.apache.hadoop.util.Shell).
   log4j:WARN Please initialize the log4j system properly.
   log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info
   ```
   After #1132, we use slf4j-simple instead of log4j. This PR remove the log4j dependecies and add `slf4j-simple`.
   This one is very similar to https://github.com/apache/orc/pull/1266.
   
   After the PR:
   ```
   java -cp ./examples/target/orc-examples-1.9.0-SNAPSHOT-uber.jar  org.apache.orc.examples.CoreWriter
   
   org.apache.orc.examples.CoreWriter
   Feb 23, 2023 7:03:48 PM org.apache.hadoop.util.NativeCodeLoader <clinit>
   WARNING: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
   [main] INFO org.apache.orc.impl.HadoopShimsCurrent - Can't get KeyProvider for ORC encryption from hadoop.security.key.provider.path.
   [main] INFO org.apache.orc.impl.PhysicalFsWriter - ORC writer created for path: my-file.orc with stripeSize: 67108864 blockSize: 268435456 compression: Compress: ZLIB buffer: 262144
   [main] INFO org.apache.orc.impl.WriterImpl - ORC writer created for path: my-file.orc with stripeSize: 67108864 options: Compress: ZLIB buffer: 262144
   
   ```
   
   ### How was this patch tested?
   manual testing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao closed pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao closed pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module
URL: https://github.com/apache/orc/pull/1421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1449256400

   @zabetak @guiyanakuang 
   The following is the latest slf4j implementation class of each module:
   
   - orc-core : slf4j-simple:jar:2.0.6:test
   - orc-tools : slf4j-simple:jar:2.0.6:runtime
   - orc-examples : slf4j-simple:jar:2.0.6:runtime
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Remove log warnings from example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1447736230

   @guiyanakuang @zabetak I have changed the title and description quoted by @zabetak. Please take a look.
   
   This PR should own to @zabetak.
   
   Thank you very much @guiyanakuang @zabetak 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443861467

   > > I think it would be simpler if I would show you what I had in mind: https://github.com/zabetak/orc/tree/ORC-1378
   > 
   > @guiyanakuang @zabetak The biggest difference between this PR and @zabetak 's PR ’is whether to add dependency (not dependency management) to pom.
   > 
   > ![image](https://user-images.githubusercontent.com/42019462/221180220-9928d766-5798-4dd8-9aa2-951f19e89c54.png)
   
   Sorry, in the example I provided, I added the slf4j-simple with the runtime scope in the parent pom.xml dependencies instead of the dependency management section. I now realize that this could be harmful. Before this change, orc-core did not transitively pass any log implementation jar. After adding slf4j-simple to the parent pom.xml dependencies, it will transitively pass it, which may cause a log library conflict for projects that depend on orc-core. Therefore, I think @zabetak's approach is better.
   
   Additionally, we can add slf4j-simple with the provided scope to orc-core, which can avoid transitive dependencies and also enable logging output when testing orc-core.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1449246186

   > I don't think the following is a precise claim because #1132 only changed `bench` modules which is not published to the Maven Central. It's just one of the `test` module which is irrelevant to the `example` module.
   > 
   > > When we run orc java examples, the following error will show in output:
   > > ...
   > > After #1132, we use slf4j-simple instead of log4j.
   > 
   > Could you revise the PR description a little more? Or, did I miss something?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1449246739

   > I don't think the following is a precise claim because #1132 only changed `bench` modules which is not published to the Maven Central. It's just one of the `test` module which is irrelevant to the `example` module.
   > 
   > > When we run orc java examples, the following error will show in output:
   > > ...
   > > After #1132, we use slf4j-simple instead of log4j.
   > 
   > Could you revise the PR description a little more? Or, did I miss something?
   
   Thank you @dongjoon-hyun.  You are right, let me fix it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1457518712

   @dongjoon-hyun @guiyanakuang @zabetak Please let me know if you have any comments. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1447724297

   Thank you @zabetak. I have merged your commit and add provicde scope in orc-core.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443497945

   Sorry, I made a mistake. Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443616575

   > I think it would be simpler if I would show you what I had in mind: https://github.com/zabetak/orc/tree/ORC-1378
   
   @guiyanakuang @zabetak The biggest difference between this PR and @zabetak 's PR ’is whether to add dependency (not dependency management) to pom.
   
   ![image](https://user-images.githubusercontent.com/42019462/221178672-42def9f4-113e-4def-b10e-4e3b36376efc.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zabetak commented on a diff in pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #1421:
URL: https://github.com/apache/orc/pull/1421#discussion_r1116746349


##########
java/examples/pom.xml:
##########
@@ -53,16 +53,33 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-hdfs</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-storage-api</artifactId>
     </dependency>
+
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>

Review Comment:
   Actually, I meant to change the scope in `java/pom.xml` not here. Log bindings rarely need to be compile dependencies since we don't want projects to be tight into one specific log implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443537310

   > [guiyanakuang@66675a9](https://github.com/guiyanakuang/orc/commit/66675a9bddecb76e3d19c4dfdf8934244ffe0e03)
   > 
   > @deshanxiao , I made some attempts based on your pull request, what do you think about it. cc @zabetak
   
   +1 for the change, Thank you. Please let me know if you think this deserves a new PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1447725841

   Test has passed:
   ![image](https://user-images.githubusercontent.com/42019462/221788530-3dca2798-817f-4053-b760-b76d3550a08f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Remove log warnings from example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1447764814

   @deshanxiao , please modify the PR title to match the content. Because this PR not only solves the problem in the example module. Perhaps the title should be "Optimize logging dependency definition for ORC project."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1449250348

   @zabetak Thank you for the reminder. You're right. At that time, I found that only orc-core was unable to output log information during testing (because other modules already had runtime simple-slf4j dependencies). Using "test" instead of "provided" is better. I'm sorry for providing misleading information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on a diff in pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on code in PR #1421:
URL: https://github.com/apache/orc/pull/1421#discussion_r1116537837


##########
java/examples/pom.xml:
##########
@@ -53,16 +53,33 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>

Review Comment:
   Great, let me try. Thank you @zabetak 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443627458

   ![image](https://user-images.githubusercontent.com/42019462/221180618-eae94ef2-4131-4884-b785-f88d3322098d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443541591

   If we remove the slf4j-simple from my PR, the slf4j may not be able to find the corresponding implementation when executing. This may have a warn log in the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Remove log warnings from example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1447765892

   cc @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443528369

   https://github.com/guiyanakuang/orc/commit/66675a9bddecb76e3d19c4dfdf8934244ffe0e03
   
   @deshanxiao , I made some attempts based on your pull request, what do you think about it.
   cc @zabetak 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443552717

   @deshanxiao Please continue with the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zabetak commented on a diff in pull request #1421: ORC-1282: [Java] Add slf4j impl to avoid warning message in example module

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #1421:
URL: https://github.com/apache/orc/pull/1421#discussion_r1115772860


##########
java/examples/pom.xml:
##########
@@ -53,16 +53,33 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-hdfs</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-storage-api</artifactId>
     </dependency>
+
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>

Review Comment:
   I noticed that slf4j-simple is declared at `compile` scope in the main `pom.xml`. Would't be sufficient to have it at `runtime` scope? 



##########
java/examples/pom.xml:
##########
@@ -53,16 +53,33 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>

Review Comment:
   Isn't it better to put the exclusions in the main `pom.xml` file so that we don't have to define them for every module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao closed pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao closed pull request #1421: ORC-1378: [Java] Optimize logging dependency definition
URL: https://github.com/apache/orc/pull/1421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao closed pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao closed pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module
URL: https://github.com/apache/orc/pull/1421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443516948

   > Sorry, I made a mistake. Fixed.
   
   It's okay, other modules did it this way before. It's just that now I think @zabetak suggestion is better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zabetak commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443613679

   > If we add dependencies in parent pom (not dependencymanagement). All modules (tools bench example) that depend on the pom.xml file will automatically inherit this dependency.
   
   Note that adding the dependency in the global dependency section it will also lead to many log (INFO) messages appearing when running tests; not sure if this is desired.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443638632

   It is reasonable to put each module into the implementation of slf4j, such as spark core module:
   https://github.com/apache/spark/blob/master/core/pom.xml
   
   After the slf4j implementation is added to all modules, there will be a lot of test logs, we should adjust it to WARN level


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1449322190

   > 
   
   Thank you @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1457831733

   @deshanxiao thank you for your efforts, thank you @zabetak and @dongjoon-hyun for the review.  I just merged it into the main branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang merged pull request #1421: ORC-1378: [Java] Optimize logging dependency definition

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang merged PR #1421:
URL: https://github.com/apache/orc/pull/1421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443198670

   Hi @zabetak, thank you for your suggestion, I update the PR. If you have time please take a look thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443591218

   > The advantage of setting it to runtime is to avoid transitive dependencies, as projects that depend on Orc have their own logging implementation. We only set it in the parent pom.xml to avoid setting it in each submodule, and this way the dependencies won't be as tightly coupled.
   
   1. I found that there are two slf4j-simple dependencies in the pom file, one in dependency and one in dependencymanagement. I remove the dependencymanagement one.
   2. If we add dependencies in parent pom. All modules (tools bench example) that depend on the pom.xml file will automatically inherit this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443545115

   I understand  @zabetak means to set it to runtime:
   If there is a specific implementation class in the compiler phase, there will be a compilation error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443200448

   cc @dongjoon-hyun @guiyanakuang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] guiyanakuang commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443574171

   The advantage of setting it to runtime is to avoid transitive dependencies, as projects that depend on Orc have their own logging implementation. We only set it in the parent pom.xml to avoid setting it in each submodule, and this way the dependencies won't be as tightly coupled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zabetak commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443595282

   I think it would be simpler if I would show you what I had in mind:
   https://github.com/zabetak/orc/tree/ORC-1378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] deshanxiao commented on pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1421:
URL: https://github.com/apache/orc/pull/1421#issuecomment-1443609167

   > The current PR also contains some files that shouldn't be there:
   > 
   > * `.my-file.orf.crc`
   > * `my-file.orc`
   >   I somehow missed to spot them in the first pass.
   
   yeah, It is good to fix git ignore to solve the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org