You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/11/15 22:00:16 UTC
Review Request 15592: SQOOP-1226 --password-file option triggers
FileSystemClosed exception at end of Oozie action
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15592/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1226
https://issues.apache.org/jira/browse/SQOOP-1226
Repository: sqoop-trunk
Description
-------
I've discussed the issue with HDFS Committer Colin and he recommended us to remove the FileSystem#close call, so this patch is doing exactly this.
Diffs
-----
src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 86b71ec
Diff: https://reviews.apache.org/r/15592/diff/
Testing
-------
All unit tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request 15592: SQOOP-1226 --password-file option triggers
FileSystemClosed exception at end of Oozie action
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15592/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 8:06 p.m.)
Review request for Sqoop.
Changes
-------
Added comment to explain why the FileSystem is not closed.
Bugs: SQOOP-1226
https://issues.apache.org/jira/browse/SQOOP-1226
Repository: sqoop-trunk
Description
-------
I've discussed the issue with HDFS Committer Colin and he recommended us to remove the FileSystem#close call, so this patch is doing exactly this.
Diffs (updated)
-----
src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 86b71ec423b40eaa5b1aca30d00ba7ea1329728a
Diff: https://reviews.apache.org/r/15592/diff/
Testing
-------
All unit tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request 15592: SQOOP-1226 --password-file option triggers
FileSystemClosed exception at end of Oozie action
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15592/#review29640
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Nov. 15, 2013, 9 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15592/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 9 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1226
> https://issues.apache.org/jira/browse/SQOOP-1226
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> I've discussed the issue with HDFS Committer Colin and he recommended us to remove the FileSystem#close call, so this patch is doing exactly this.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/util/password/FilePasswordLoader.java 86b71ec
>
> Diff: https://reviews.apache.org/r/15592/diff/
>
>
> Testing
> -------
>
> All unit tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>