You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/30 00:00:49 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #7146: Fixes SQLServer insert statement, parse no into keyword.
dongzl opened a new pull request #7146:
URL: https://github.com/apache/shardingsphere/pull/7146
For #6478 .
Changes proposed in this pull request:
- fixes SQLServer insert statement, parse no into keyword.
- add SQLServer and MySQL sql test case for insert no into keyword.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7146: Fixes SQLServer insert statement, parse no into keyword.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7146:
URL: https://github.com/apache/shardingsphere/pull/7146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #7146: Fixes SQLServer insert statement, parse no into keyword.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7146:
URL: https://github.com/apache/shardingsphere/pull/7146#issuecomment-683358283
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=h1) Report
> Merging [#7146](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/352f6961795e5d4aaf17bbf874775e1e0a244c0b?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7146 +/- ##
============================================
- Coverage 75.58% 75.57% -0.01%
Complexity 469 469
============================================
Files 1219 1219
Lines 21688 21688
Branches 3930 3930
============================================
- Hits 16392 16391 -1
Misses 4271 4271
- Partials 1025 1026 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7146/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `52.17% <0.00%> (-2.18%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=footer). Last update [352f696...a16f673](https://codecov.io/gh/apache/shardingsphere/pull/7146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7146: Fixes SQLServer insert statement, parse no into keyword.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7146:
URL: https://github.com/apache/shardingsphere/pull/7146#issuecomment-683358513
## Pull Request Test Coverage Report for [Build 14246](https://coveralls.io/builds/33094049)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **4059** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.003%**) to **35.628%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/SQLServerStatementParser.java](https://coveralls.io/builds/33094049/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FSQLServerStatementParser.java#L716) | 4059 | 29.96% |
<!-- | **Total:** | **4059** | | -->
| Totals | [](https://coveralls.io/builds/33094049) |
| :-- | --: |
| Change from base [Build 14243](https://coveralls.io/builds/33090264): | 0.003% |
| Covered Lines: | 35533 |
| Relevant Lines: | 99733 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org