You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/09/10 19:12:40 UTC

[Impala-ASF-CR] IMPALA-10093: Replace urllib with wget to download python deps

Tim Armstrong has uploaded a new patch set (#3) to the change originally created by guojingfeng. ( http://gerrit.cloudera.org:8080/16344 )

Change subject: IMPALA-10093: Replace urllib with wget to download python deps
......................................................................

IMPALA-10093: Replace urllib with wget to download python deps

When build impala in Company internal network, pip_download.py
failed to download dependency eggs from https engpoint Although
correcly set system proxy like http_proxy, https_proxy. Is is
a issue of python2's urllib. I just replace urllib with wget
which can works well with system proxy like https_proxy.

Change-Id: I146d93312701fd682420cb65cf4738bc030f3cfb
---
M infra/python/deps/pip_download.py
1 file changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/16344/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I146d93312701fd682420cb65cf4738bc030f3cfb
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 3
Gerrit-Owner: guojingfeng <gu...@tencent.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>