You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by James Mason <ma...@apache.org> on 2004/10/11 17:23:00 UTC

Re: cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/method UnlockMethod.java

+1. Yesterday was basically a test run for me, so I don't mind redoing
the little I did.

-James

On Mon, 2004-10-11 at 03:33, Oliver Zeigermann wrote:
> Folks,
> 
> made this tiny patch to make Netdrive unlock commands succeed. For 
> unknown reasons Netdrive adds trainling whitspace to the lock token.
> 
> Should we take this over into the 2.1b2 release? I am +1 for it.
> 
> Oliver
> 
> ozeigermann@apache.org schrieb:
> 
> > ozeigermann    2004/10/11 03:20:21
> > 
> >   Modified:    src/webdav/server/org/apache/slide/webdav/method Tag:
> >                         SLIDE_2_1_RELEASE_BRANCH UnlockMethod.java
> >   Log:
> >   Applied trimming to the lock id as Netdrive sends it with trailing spaces.
> >   This fixes unlocking with Netdrive
> >   
> >   Revision  Changes    Path
> >   No                   revision
> >   No                   revision
> >   1.39.2.2  +4 -4      jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/UnlockMethod.java
> >   
> >   Index: UnlockMethod.java
> >   ===================================================================
> >   RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/method/UnlockMethod.java,v
> >   retrieving revision 1.39.2.1
> >   retrieving revision 1.39.2.2
> >   diff -u -r1.39.2.1 -r1.39.2.2
> >   --- UnlockMethod.java	12 Sep 2004 17:35:50 -0000	1.39.2.1
> >   +++ UnlockMethod.java	11 Oct 2004 10:20:21 -0000	1.39.2.2
> >   @@ -125,7 +125,7 @@
> >    			resourcePath = "/";
> >    		}
> >    
> >   -		lockId = requestHeaders.getLockToken();
> >   +		lockId = requestHeaders.getLockToken().trim(); // XXX trim is needed for Netdrive which sends trailing spaces
> >    		if (lockId == null) {
> >    			sendError(WebdavStatus.SC_PRECONDITION_FAILED,
> >    					LOCK_TOKEN_HEADER_MISSING);
> >   
> >   
> >   
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> > 
> > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org