You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/06 04:08:55 UTC
[GitHub] [pulsar] nodece opened a new pull request, #17482: [feat][python] Add basic authentication
nodece opened a new pull request, #17482:
URL: https://github.com/apache/pulsar/pull/17482
### Motivation
Python misses the basic authentication.
### Verifying this change
Added `test_basic_auth` test to cover this feature.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `doc-required`
Add Python basic authentication documentation.
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #17482: [feat][python] Add basic authentication
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17482:
URL: https://github.com/apache/pulsar/pull/17482#issuecomment-1237942832
> Could you add tests for a wrong username or secret? It's better to show what will happen in this case.
I added this test, please help review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17482: [feat][python] Add basic authentication
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17482:
URL: https://github.com/apache/pulsar/pull/17482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #17482: [feat][python] Add basic authentication
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #17482:
URL: https://github.com/apache/pulsar/pull/17482#issuecomment-1237912451
https://github.com/apache/pulsar/pull/15822 has merged to branch-2.11. It's good to have this one in 2.11.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org