You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/07 16:11:26 UTC

[GitHub] zhaijack opened a new pull request #1354: Issue 1118: refine handlerBase to let only ConsumerImpl and ProducerImpl have client-cnx

zhaijack opened a new pull request #1354: Issue 1118: refine handlerBase to let only ConsumerImpl and ProducerImpl have client-cnx
URL: https://github.com/apache/incubator-pulsar/pull/1354
 
 
   ### Motivation
   
    class HandlerBase contains 2 parts:
   - handler state;  this is need for all handler.
   - client_cnx connection handling; this part only useful in ConsumerImpl and ProducerImpl, while not need for PartitionedConsumer, PartitionedProducer, TopicsConsumer.
   
   This change would like to refine HandlerBase into 2 parts, to make client_cnx connection handling only served in ConsumerImpl and ProducerImpl
   
   ### Modifications
   
   Split HandlerBase into 2 class: 
   - HandlerState: handling the state of every consumer/producer;
   - ConnectionHandler: handling the client_cnx connection for ConsumerImpl and ProducerImpl.
   
   ### Result
   no api changes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services