You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sis.apache.org by phuong hao nguyen thi <ng...@gmail.com> on 2018/07/13 04:21:23 UTC
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Hello Martin and all,
At the present is the end of the second phase of the project, in order to
better prepare for the final phase, I created a summary include : my work
in phase second ( 1) , summary of the system (2), work in the future (3)
inside this document:
https://docs.google.com/document/d/1Xnuwy2tP3wQvBOPV4ZYvEix8IJbclKhAqtQJMp1hzRM/edit?usp=sharing
Can anyone give me comments and advices ?
Thanks so much.
Hao
On Thu, Jul 12, 2018 at 9:06 PM phuong hao nguyen thi <
nguyenthiphuonghao243@gmail.com> wrote:
> Bonjour Martin,
> >>Est-ce que tu pourrais faire un point sur l'état de ton travail sur la
> liste public de Apache SIS?
> Oui , je peux, je vais le finir ce soir avec le résumé .
> >> application/sis-webapp/src/main/java/org/apache/sis/services
> /catalog/schema/,
> il semble y avoir une copie des fichiers XSD de l'OGC. Ces copies sont
> pour quoi faire? Est-ce qu'on peut les supprimer?
> Je les utilise pour faciliter la comparaison lors de l'implémentation
> standard. Actuellement, ils peuvent être supprimés et je vais les supprimer
> dans le prochain code push
> >>Certains fichiers comme DiscoveryDAO.java contiennent des chemins vers
> des fichiers sur ton disque ("/home/haonguyen/data/"). Ces fichiers ne
> fonctionneront pas sur d'autres ordinateurs. Je propose que tu créé un
> autre projet, séparé de application/sis-webapp. Dans cet autre projet,
> tu peux déménager toutes les classes qui sont spécifiques à tes données.
> Il faudrait que dans application/sis-webapp, il ne reste rien qui pointe
> directement sur "/home/haonguyen/data/".
> Oui je comprends , je vais éditer cette section.
> >>
> Même chose pour OGCServiceDAO: il ne contient pas de lien vers
> "/home/haonguyen/data/", mais ce qu'il contient des numéros de
> téléphones et adresses de courriels.
> Le contenu actuel de cette section n'est que des examples et je les
> destaillerai plus tard.
>
> Merci beaucoup,
> Hao
>
> On Thu, Jul 12, 2018 at 7:12 PM Martin Desruisseaux <
> martin.desruisseaux@geomatys.com> wrote:
>
>> Bonjour Hao
>>
>> Est-ce que tu pourrais faire un point sur l'état de ton travail sur la
>> liste public de Apache SIS?
>>
>> Dans le répertoire
>>
>> application/sis-webapp/src/main/java/org/apache/sis/services/catalog/schema/,
>> il semble y avoir une copie des fichiers XSD de l'OGC. Ces copies sont
>> pour quoi faire? Est-ce qu'on peut les supprimer?
>>
>> Certains fichiers comme DiscoveryDAO.java contiennent des chemins vers
>> des fichiers sur ton disque ("/home/haonguyen/data/"). Ces fichiers ne
>> fonctionneront pas sur d'autres ordinateurs. Je propose que tu créé un
>> autre projet, séparé de application/sis-webapp. Dans cet autre projet,
>> tu peux déménager toutes les classes qui sont spécifiques à tes données.
>> Il faudrait que dans application/sis-webapp, il ne reste rien qui pointe
>> directement sur "/home/haonguyen/data/".
>>
>> Même chose pour OGCServiceDAO: il ne contient pas de lien vers
>> "/home/haonguyen/data/", mais ce qu'il contient des numéros de
>> téléphones et adresses de courriels.
>>
>> Est-ce que tu peux donner un résumé sur dev@sis.apache.org à propos de
>> quelle sont les classes principales?
>>
>> Martin
>>
>>
>>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Oh , I understand , thanks for the document . :))
On Wed, Aug 15, 2018 at 10:51 PM Martin Desruisseaux <
martin.desruisseaux@geomatys.com> wrote:
> Le 15/08/2018 à 10:37, phuong hao nguyen thi a écrit :
>
> > I think this is what you also did for Catalog on the Web before this
> XJC trial, isn't it?
>
> Yes, however,I found that the OGC standard provides a lot of schema XSD,
> so I think if jaxb binding run automatically, can code faster (in my
> opinion :) )
>
> Yes. But human intervention still required anyway. The following links
> describe some issues when generating Java classes automatically from XSD
> (using XJC or other tools like Eclipse Modelling Framework):
>
> - English:
> http://sis.apache.org/book/en/developer-guide.html#SpecificationToInterfaces
> - French:
> http://sis.apache.org/book/fr/developer-guide.html#SpecificationToInterfaces
>
> Martin
>
>
>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by Martin Desruisseaux <ma...@geomatys.com>.
Le 15/08/2018 à 10:37, phuong hao nguyen thi a écrit :
> > I think this is what you also did for Catalog on the Web before
> this XJC trial, isn't it?
>
> Yes, however,I found that the OGC standard provides a lot of schema
> XSD, so I think if jaxb binding run automatically, can code faster (in
> my opinion :) )
>
Yes. But human intervention still required anyway. The following links
describe some issues when generating Java classes automatically from XSD
(using XJC or other tools like Eclipse Modelling Framework):
* English:
http://sis.apache.org/book/en/developer-guide.html#SpecificationToInterfaces
* French:
http://sis.apache.org/book/fr/developer-guide.html#SpecificationToInterfaces
Martin
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hello Martin,
Thanks for the response :)
> I think this is what you also did for Catalog on the Web before this XJC
trial, isn't it?
Yes, however,I found that the OGC standard provides a lot of schema XSD, so
I think if jaxb binding run automatically, can code faster (in my opinion
:) ) and
So if something new I will report later
Thanks
Hao
On Wed, Aug 15, 2018 at 10:09 PM Martin Desruisseaux <
martin.desruisseaux@geomatys.com> wrote:
> Hello Hao
>
> Le 14/08/2018 à 18:38, phuong hao nguyen thi a écrit :
>
> (…snip…)
>
> [ERROR] Base complex type "AdditionalParametersBaseType" is derived by
> restriction, while this complex type "AdditionalParametersType" is derived
> by extension. This is not currently handled by XJC, (…snip…)
>
> The error message suggests an XJC limitations. Together with the other
> errors you reported, it suggests that it may be easier to derive the Java
> classes by hand, as you did.
>
>
> Do you encountered these errors yet ? If yes, can you help me how to fix
> it ?
>
> I have not encountered those errors myself, since I put JAXB annotations
> by hand. I think this is what you also did for Catalog on the Web before
> this XJC trial, isn't it? The errors you reported seem to indicate that the
> way you did was a good practical approach.
>
> Martin
>
>
>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by Martin Desruisseaux <ma...@geomatys.com>.
Hello Hao
Le 14/08/2018 à 18:38, phuong hao nguyen thi a écrit :
> (…snip…)
>
> [ERROR] Base complex type "AdditionalParametersBaseType" is derived by
> restriction, while this complex type "AdditionalParametersType" is
> derived by extension. This is not currently handled by XJC, (…snip…)
>
The error message suggests an XJC limitations. Together with the other
errors you reported, it suggests that it may be easier to derive the
Java classes by hand, as you did.
> Do you encountered these errors yet ? If yes, can you help me how to
> fix it ?
>
I have not encountered those errors myself, since I put JAXB annotations
by hand. I think this is what you also did for Catalog on the Web before
this XJC trial, isn't it? The errors you reported seem to indicate that
the way you did was a good practical approach.
Martin
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
And I have a problem , I'm trying to mapping from XSD schema to java using
jaxb binding in netbean but have errors
Example : with a schema file :
http://schemas.opengis.net/ows/2.0/ows19115subset.xsd , error as
[ERROR] Base complex type "AdditionalParametersBaseType" is derived by
restriction, while this complex type "AdditionalParametersType" is derived
by extension. This is not currently handled by XJC, but we are seeking
input on this issue. Please report this to the JAXB team.
line 54 of
file:/home/haonguyen/NetBeansProjects/JavaApplication1/xml-resources/jaxb/ows/
schemas.opengis.net/ows/2.0/owsAdditionalParameters.xsd
[ERROR] Property "Title" is already defined. Use <jaxb:property> to
resolve this conflict.
line 261 of
file:/home/haonguyen/NetBeansProjects/JavaApplication1/xml-resources/jaxb/ows/
www.w3.org/1999/xlink.xsd
[ERROR] The following location is relevant to the above error
line 246 of
file:/home/haonguyen/NetBeansProjects/JavaApplication1/xml-resources/jaxb/ows/
www.w3.org/1999/xlink.xsd
[ERROR] Property "Title" is already defined. Use <jaxb:property> to
resolve this conflict.
line 232 of
file:/home/haonguyen/NetBeansProjects/JavaApplication1/xml-resources/jaxb/ows/
www.w3.org/1999/xlink.xsd
[ERROR] The following location is relevant to the above error
line 219 of
file:/home/haonguyen/NetBeansProjects/JavaApplication1/xml-resources/jaxb/ows/
www.w3.org/1999/xlink.xsd
Do you encountered these errors yet ? If yes, can you help me how to fix
it ?
Thanks
Hao
On Tue, Aug 14, 2018 at 11:22 PM phuong hao nguyen thi <
nguyenthiphuonghao243@gmail.com> wrote:
> Hello Martin and all,
> All the codes that I đi in the GSOC2018 project I pushed up the github
> server : https://github.com/haonguyen123/sis
> client : https://github.com/haonguyen123/CSWWebApplication
> Can you check and give me some comments so that I can improve ?
>
> Thanks so much
> Hao
>
> On Tue, Aug 14, 2018 at 8:52 AM phuong hao nguyen thi <
> nguyenthiphuonghao243@gmail.com> wrote:
>
>> Hello martin,
>> Thanks for reminder,
>> I'm creating a lot of unit tests but uncompleted. I will try to finish as
>> soon as possible.
>>
>> Thanks
>> Hao
>>
>> On Tue, Aug 14, 2018 at 3:17 PM Martin Desruisseaux <
>> martin.desruisseaux@geomatys.com> wrote:
>>
>>> Hello Hao
>>>
>>> The report at [1] looks good, thanks! I do not have major modification
>>> to propose at this time. I think that today is the deadline for student to
>>> submit their report, is that right? If you have any commit pending, please
>>> make sure they are pushed.
>>>
>>> Have a nice day,
>>>
>>> Martin
>>>
>>> [1] https://phuonghaonguyen.blogspot.com/2018/08/i.html
>>>
>>>
>>> Le 09/08/2018 à 06:47, phuong hao nguyen thi a écrit :
>>>
>>> Hello Martin and all,
>>> I'am create a blog post in the blogger :
>>> https://phuonghaonguyen.blogspot.com/2018/08/i.html
>>> that describes the work I have done in GSOC 2018 with the project: *Implement
>>> OGC Catalog Service for the Web.*
>>>
>>> I tried running (demo) the web service on a personal computer with the
>>> public ip address that I will update in this document :
>>>
>>> https://docs.google.com/document/d/1i2PnD1Z1TuChaEjEBXxLBYvoTl5fTkRJBvaXwTeQA98/edit
>>> because, it a dynamic IP address .
>>> I will run it from now (9/8/2018) until the end of this week(12/8/2018)
>>> so everyone can access it.
>>> You can view and give me suggestions, comments, what I need to add to
>>> the project is more complete. As anyone interested in this project can
>>> refer and contribute more.
>>>
>>> Thanks all so much.
>>>
>>> Hao
>>>
>>>
>>>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hello Martin and all,
All the codes that I đi in the GSOC2018 project I pushed up the github
server : https://github.com/haonguyen123/sis
client : https://github.com/haonguyen123/CSWWebApplication
Can you check and give me some comments so that I can improve ?
Thanks so much
Hao
On Tue, Aug 14, 2018 at 8:52 AM phuong hao nguyen thi <
nguyenthiphuonghao243@gmail.com> wrote:
> Hello martin,
> Thanks for reminder,
> I'm creating a lot of unit tests but uncompleted. I will try to finish as
> soon as possible.
>
> Thanks
> Hao
>
> On Tue, Aug 14, 2018 at 3:17 PM Martin Desruisseaux <
> martin.desruisseaux@geomatys.com> wrote:
>
>> Hello Hao
>>
>> The report at [1] looks good, thanks! I do not have major modification to
>> propose at this time. I think that today is the deadline for student to
>> submit their report, is that right? If you have any commit pending, please
>> make sure they are pushed.
>>
>> Have a nice day,
>>
>> Martin
>>
>> [1] https://phuonghaonguyen.blogspot.com/2018/08/i.html
>>
>>
>> Le 09/08/2018 à 06:47, phuong hao nguyen thi a écrit :
>>
>> Hello Martin and all,
>> I'am create a blog post in the blogger :
>> https://phuonghaonguyen.blogspot.com/2018/08/i.html
>> that describes the work I have done in GSOC 2018 with the project: *Implement
>> OGC Catalog Service for the Web.*
>>
>> I tried running (demo) the web service on a personal computer with the
>> public ip address that I will update in this document :
>>
>> https://docs.google.com/document/d/1i2PnD1Z1TuChaEjEBXxLBYvoTl5fTkRJBvaXwTeQA98/edit
>> because, it a dynamic IP address .
>> I will run it from now (9/8/2018) until the end of this week(12/8/2018)
>> so everyone can access it.
>> You can view and give me suggestions, comments, what I need to add to the
>> project is more complete. As anyone interested in this project can refer
>> and contribute more.
>>
>> Thanks all so much.
>>
>> Hao
>>
>>
>>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hello martin,
Thanks for reminder,
I'm creating a lot of unit tests but uncompleted. I will try to finish as
soon as possible.
Thanks
Hao
On Tue, Aug 14, 2018 at 3:17 PM Martin Desruisseaux <
martin.desruisseaux@geomatys.com> wrote:
> Hello Hao
>
> The report at [1] looks good, thanks! I do not have major modification to
> propose at this time. I think that today is the deadline for student to
> submit their report, is that right? If you have any commit pending, please
> make sure they are pushed.
>
> Have a nice day,
>
> Martin
>
> [1] https://phuonghaonguyen.blogspot.com/2018/08/i.html
>
>
> Le 09/08/2018 à 06:47, phuong hao nguyen thi a écrit :
>
> Hello Martin and all,
> I'am create a blog post in the blogger :
> https://phuonghaonguyen.blogspot.com/2018/08/i.html
> that describes the work I have done in GSOC 2018 with the project: *Implement
> OGC Catalog Service for the Web.*
>
> I tried running (demo) the web service on a personal computer with the
> public ip address that I will update in this document :
>
> https://docs.google.com/document/d/1i2PnD1Z1TuChaEjEBXxLBYvoTl5fTkRJBvaXwTeQA98/edit
> because, it a dynamic IP address .
> I will run it from now (9/8/2018) until the end of this week(12/8/2018) so
> everyone can access it.
> You can view and give me suggestions, comments, what I need to add to the
> project is more complete. As anyone interested in this project can refer
> and contribute more.
>
> Thanks all so much.
>
> Hao
>
>
>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by Martin Desruisseaux <ma...@geomatys.com>.
Hello Hao
The report at [1] looks good, thanks! I do not have major modification
to propose at this time. I think that today is the deadline for student
to submit their report, is that right? If you have any commit pending,
please make sure they are pushed.
Have a nice day,
Martin
[1] https://phuonghaonguyen.blogspot.com/2018/08/i.html
Le 09/08/2018 à 06:47, phuong hao nguyen thi a écrit :
> Hello Martin and all,
> I'am create a blog post in the blogger
> : https://phuonghaonguyen.blogspot.com/2018/08/i.html
> that describes the work I have done in GSOC 2018 with the
> project: *Implement OGC Catalog Service for the Web.*
> *
> *
> I tried running (demo) the web service on a personal computer with the
> public ip address that I will update in this document :
> https://docs.google.com/document/d/1i2PnD1Z1TuChaEjEBXxLBYvoTl5fTkRJBvaXwTeQA98/edit
> because, it a dynamic IP address .
> I will run it from now (9/8/2018) until the end of this
> week(12/8/2018) so everyone can access it.
> You can view and give me suggestions, comments, what I need to add to
> the project is more complete. As anyone interested in this project can
> refer and contribute more.
>
> Thanks all so much.
>
> Hao
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hi Martin,
Oh , It build success :)
Thanks you so much .
Hao
On Tue, Jul 31, 2018 at 4:45 PM Martin Desruisseaux <
martin.desruisseaux@geomatys.com> wrote:
> Hello Hao
>
> Le 31/07/2018 à 05:32, phuong hao nguyen thi a écrit :
>
> I have merge and I make "mvn install " and has error:
> [ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5, Time elapsed:
> 11.906 s <<< FAILURE! - in org.apache.sis.test.suite.MetadataTestSuite
> [ERROR]
> testGetIdentifier(org.apache.sis.metadata.iso.citation.CitationsTest) Time
> elapsed: 0.001 s <<< FAILURE!
> java.lang.AssertionError: expected:<ESRI:ArcGIS> but was:<null>
>
> I suggest to delete your $SIS_DATA/Databases/SpatialMetadata/ directory
> for letting SIS re-create it with updated database content.
>
> Martin
>
>
>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hello Martin and all,
I'am create a blog post in the blogger :
https://phuonghaonguyen.blogspot.com/2018/08/i.html
that describes the work I have done in GSOC 2018 with the project: *Implement
OGC Catalog Service for the Web.*
I tried running (demo) the web service on a personal computer with the
public ip address that I will update in this document :
https://docs.google.com/document/d/1i2PnD1Z1TuChaEjEBXxLBYvoTl5fTkRJBvaXwTeQA98/edit
because, it a dynamic IP address .
I will run it from now (9/8/2018) until the end of this week(12/8/2018) so
everyone can access it.
You can view and give me suggestions, comments, what I need to add to the
project is more complete. As anyone interested in this project can refer
and contribute more.
Thanks all so much.
Hao
On Thu, Aug 9, 2018 at 8:09 AM phuong hao nguyen thi <
nguyenthiphuonghao243@gmail.com> wrote:
> Martin,
> Merci de votre courrier :)
> >> Dans la section 4.2, est-ce que tu pourrais ajouter un paragraphe
> résumant quelles classes utilisent les dépendances?
> Oui je vais les ajouter au document .
> >> Dans la section 4.3, est-ce que tu peux préciser si tu as généré les
> classes POJOs à partir du schéma XSD, ou est-ce que tu as écrit toutes les
> classes POJOs à la main?
>
> Actuellement, tous ces classes POJOs sont écrits par moi-même sur la base
> du XSD. J'essaie de trouver un moyen de basculer automatiquement en
> utilisant les outils JAXB, mais c'est dans le futur. Et je le remarquerai
> aussi dans la documentation :))
> Alors , je vais creer une blog, mettre à jour mes documents et les envoyer
> au public mail .
>
> Merci
> Hao
>
> On Thu, Aug 9, 2018 at 5:47 AM Martin Desruisseaux <
> martin.desruisseaux@geomatys.com> wrote:
>
>> Bonjour Hao
>>
>> Ça m'a l'air bien tout ça :-)
>>
>> Dans la section 4.2, est-ce que tu pourrais ajouter un paragraphe
>> résumant quelles classes utilisent les dépendances?
>>
>> Dans la section 4.3, est-ce que tu peux préciser si tu as généré les
>> classes POJOs à partir du schéma XSD, ou est-ce que tu as écrit toutes les
>> classes POJOs à la main? Si tu as généré les classes à partir du schéma
>> XSD, est-ce que tu peux nous donner la commande JAXB que tu as utilisé?
>>
>> Je pense que tu peux donner le lien sur la liste dev@sis.apache.org,
>> même si ce n'est pas complètement terminé. Tu peux aussi ajouter encore du
>> code, c'est bienvenue :-). Le client aussi c'est bien d'avoir poussé le
>> code.
>>
>> Bonne journée!
>>
>> Martin
>>
>>
>> Le 08/08/2018 à 19:36, phuong hao nguyen thi a écrit :
>>
>> Bonjour Martin,
>> C'est lien de mon document :
>> https://docs.google.com/document/d/1oDxF63SuM2Q_E2Bj8pnwW-eNzuu8wJZ5h-Q9XNRZ-K8/edit?usp=sharing
>> Avant d'envoyer le publish mail, pourriez- vous m'aider à vérifier si
>> tout va bien ? Y a-t-il un endroit inconnu ou où dois-je l'ajouter ?
>> Avec le code client web, j'ai poussé sur le github:
>> https://github.com/haonguyen123/CSWWebApplication
>> C'est bien ?
>> Pendant ce temps puis-je encore ajouter mon code?
>>
>>
>>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by Martin Desruisseaux <ma...@geomatys.com>.
Hello Hao
Le 31/07/2018 à 05:32, phuong hao nguyen thi a écrit :
> I have merge and I make "mvn install " and has error:
> [ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5, Time
> elapsed: 11.906 s <<< FAILURE! - in
> org.apache.sis.test.suite.MetadataTestSuite
> [ERROR]
> testGetIdentifier(org.apache.sis.metadata.iso.citation.CitationsTest)
> Time elapsed: 0.001 s <<< FAILURE!
> java.lang.AssertionError: expected:<ESRI:ArcGIS> but was:<null>
I suggest to delete your $SIS_DATA/Databases/SpatialMetadata/ directory
for letting SIS re-create it with updated database content.
Martin
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by phuong hao nguyen thi <ng...@gmail.com>.
Hello Martin and all,
Thanks for response,
I have merge and I make "mvn install " and has error:
[ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5, Time elapsed:
11.906 s <<< FAILURE! - in org.apache.sis.test.suite.MetadataTestSuite
[ERROR]
testGetIdentifier(org.apache.sis.metadata.iso.citation.CitationsTest) Time
elapsed: 0.001 s <<< FAILURE!
java.lang.AssertionError: expected:<ESRI:ArcGIS> but was:<null>
at
org.apache.sis.metadata.iso.citation.CitationsTest.testGetIdentifier(CitationsTest.java:125)
[ERROR] testGetTitles(org.apache.sis.metadata.iso.citation.CitationsTest)
Time elapsed: 0 s <<< FAILURE!
java.lang.AssertionError: GEOTIFF
at
org.apache.sis.metadata.iso.citation.CitationsTest.testGetTitles(CitationsTest.java:209)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] CitationsTest.testGetIdentifier:125 expected:<ESRI:ArcGIS> but
was:<null>
[ERROR] CitationsTest.testGetTitles:209 GEOTIFF
[INFO]
[ERROR] Tests run: 397, Failures: 2, Errors: 0, Skipped: 5
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache SIS ......................................... SUCCESS [
3.402 s]
[INFO] Apache SIS build helper ............................ SUCCESS [
5.512 s]
[INFO] Apache SIS core modules ............................ SUCCESS [
0.549 s]
[INFO] Apache SIS utilities ............................... SUCCESS [
11.927 s]
[INFO] Apache SIS metadata ................................ FAILURE [
13.173 s]
[INFO] Apache SIS referencing ............................. SKIPPED
[INFO] Apache SIS referencing by geographic identifiers ... SKIPPED
[INFO] Apache SIS features ................................ SKIPPED
[INFO] Apache SIS rasters ................................. SKIPPED
[INFO] Apache SIS storage ................................. SKIPPED
[INFO] Apache SIS common storage .......................... SKIPPED
[INFO] Apache SIS portrayal ............................... SKIPPED
[INFO] Apache SIS Shapefile storage ....................... SKIPPED
[INFO] Apache SIS XML storage ............................. SKIPPED
[INFO] Apache SIS SQL storage ............................. SKIPPED
[INFO] Apache SIS netCDF storage .......................... SKIPPED
[INFO] Apache SIS GeoTIFF storage ......................... SKIPPED
[INFO] Apache SIS Earth Observation storage ............... SKIPPED
[INFO] Apache SIS bindings for Proj4 ...................... SKIPPED
[INFO] Apache SIS applications ............................ SKIPPED
[INFO] Apache SIS console ................................. SKIPPED
[INFO] Apache SIS application for JavaFX .................. SKIPPED
[INFO] Apache SIS web services layer ...................... SKIPPED
[INFO] Apache SIS profiles ................................ SKIPPED
[INFO] Apache SIS French profiles ......................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 35.520 s
[INFO] Finished at: 2018-07-31T09:49:02+07:00
[INFO] Final Memory: 45M/531M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test)
on project sis-metadata: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/haonguyen/GSOC2018/sis/core/sis-metadata/target/surefire-reports for
the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn <goals> -rf :sis-metadata
But when I use "mvn clean install -DskipTests -Dfindbugs.skip=true
-Dpmd.skip=true -Dmaven.javadoc.skip=true" it build success .
Does it have any effect ?
>>I suspect that most classes in CSW and OWS packages are for internal use
by the "sis-webapp" module. Is that right? If yes, then we may not need
getter and setter methods, since no one else than "sis-webapp" would use
those classes. Instead, the JAXB annotations could be on the fields
directly. This would make smaller classes.
I don't understand , Does that mean I don't need use get set for these
classes ?
Thanks
Hao
On Mon, Jul 30, 2018 at 4:17 AM Martin Desruisseaux <
martin.desruisseaux@geomatys.com> wrote:
> Hello Hao
>
> I have pushed on [1] a clone of you work + merge with latest SIS
> development and removal of trailing spaces (for allowing Checkstyle checks
> to pass). You can merge with your work if convenient. Note however that
> recent SIS development introduces one change in metadata database: when
> creating table in the databases, the ISO prefixes (for example "CI_" in
> "CI_Citation") is now dropped. In other words, the table created by SIS
> in the database is no longer named "CI_Citation", but is named "Citation"
> instead. This change is motivated in part because, in my understanding, ISO
> is dropping the prefixes in new standards.
>
> On the Google Summer of Code work, I suggest to do the following tasks:
>
> - Make sure that "mvn install" works from the command line, with tests
> enabled. Please let us know if you encounter any issue.
> - In org.apache.sis.services.ows.package-info, add a Javadoc telling
> from which standard those classes come from, how they were generated (JAXB
> compiler?) and, if you modified the result, what were the modifications.
> - In the org.apache.sis.services.ows package, classes Address,
> Telephone and OnlineResource seem similar to ISO 19115 classes of the
> same name. Can you add a note in their javadoc describing the relationship
> with ISO 19115?
> - RequestMethod has javadoc interleaved with JAXB annotations. The
> order should be class Javadoc, then annotations, then class declaration.
> Same for OwsServiceProvider, OwsServiceIdentification and others.
> - You can remove the @SuppressWarnings("CloneableClassWithoutClone")
> annotations; they do not apply to the classes in this package.
> - org.apache.sis.services.csw.ogcservice.GetCapabilities, Capabilities,
> InsertResult and others have the license header at the wrong location.
> - org.apache.sis.services.csw.impl.OGCServiceImpl and
> org.apache.sis.services.csw.discovery.GetDomainResponse are completely
> empty. Are these classes used?
>
> Many classes, fields or methods have empty javadoc tags. For example:
>
> /**
> *
> * @param transaction
> * @return
> */
>
> Ideally the Javadoc should be completed. But if not (for example because
> they are redundant with other information), I think it is better to
> completely remove those tags instead than keeping empty tags, in order to
> avoid giving a false impression of completeness. But if you plan to
> complete javadoc, before doing so see next item.
>
> I suspect that most classes in CSW and OWS packages are for internal use
> by the "sis-webapp" module. Is that right? If yes, then we may not need
> getter and setter methods, since no one else than "sis-webapp" would use
> those classes. Instead, the JAXB annotations could be on the fields
> directly. This would make smaller classes.
>
> Thanks!
>
> Martin
>
> [1] https://github.com/desruisseaux/sis/tree/CSW
>
>
Re: Google Summer of Code 2018 : Implement OGC Catalog Service for
the Web (CSW)
Posted by Martin Desruisseaux <ma...@geomatys.com>.
Hello Hao
I have pushed on [1] a clone of you work + merge with latest SIS
development and removal of trailing spaces (for allowing Checkstyle
checks to pass). You can merge with your work if convenient. Note
however that recent SIS development introduces one change in metadata
database: when creating table in the databases, the ISO prefixes (for
example "CI_" in "CI_Citation") is now dropped. In other words, the
table created by SIS in the database is no longer named "CI_Citation",
but is named "Citation" instead. This change is motivated in part
because, in my understanding, ISO is dropping the prefixes in new standards.
On the Google Summer of Code work, I suggest to do the following tasks:
* Make sure that "mvn install" works from the command line, with tests
enabled. Please let us know if you encounter any issue.
* In org.apache.sis.services.ows.package-info, add a Javadoc telling
from which standard those classes come from, how they were generated
(JAXB compiler?) and, if you modified the result, what were the
modifications.
* In the org.apache.sis.services.ows package, classes Address,
Telephone and OnlineResource seem similar to ISO 19115 classes of
the same name. Can you add a note in their javadoc describing the
relationship with ISO 19115?
* RequestMethod has javadoc interleaved with JAXB annotations. The
order should be class Javadoc, then annotations, then class
declaration. Same for OwsServiceProvider, OwsServiceIdentification
and others.
* You can remove the @SuppressWarnings("CloneableClassWithoutClone")
annotations; they do not apply to the classes in this package.
* org.apache.sis.services.csw.ogcservice.GetCapabilities,
Capabilities, InsertResult and others have the license header at the
wrong location.
* org.apache.sis.services.csw.impl.OGCServiceImpl and
org.apache.sis.services.csw.discovery.GetDomainResponse are
completely empty. Are these classes used?
Many classes, fields or methods have empty javadoc tags. For example:
/**
*
* @param transaction
* @return
*/
Ideally the Javadoc should be completed. But if not (for example because
they are redundant with other information), I think it is better to
completely remove those tags instead than keeping empty tags, in order
to avoid giving a false impression of completeness. But if you plan to
complete javadoc, before doing so see next item.
I suspect that most classes in CSW and OWS packages are for internal use
by the "sis-webapp" module. Is that right? If yes, then we may not need
getter and setter methods, since no one else than "sis-webapp" would use
those classes. Instead, the JAXB annotations could be on the fields
directly. This would make smaller classes.
Thanks!
Martin
[1] https://github.com/desruisseaux/sis/tree/CSW