[ant] branch master updated: change the default of authenticateOnRedirect

[bo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bodewig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git


The following commit(s) were added to refs/heads/master by this push:
     new 82f5edc  change the default of authenticateOnRedirect
82f5edc is described below

commit 82f5edcf49002943773a165464e152b1d75a68a8
Author: Stefan Bodewig <bo...@apache.org>
AuthorDate: Thu Dec 23 18:25:47 2021 +0100

    change the default of authenticateOnRedirect
---
 WHATSNEW                                        | 14 +++++++++-----
 manual/Tasks/get.html                           |  2 +-
 src/main/org/apache/tools/ant/taskdefs/Get.java |  2 +-
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/WHATSNEW b/WHATSNEW
index 6dcfe9b..ff6e43a 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -1,6 +1,15 @@
 Changes from Ant 1.10.12 TO Ant 1.10.13
 =======================================
 
+Changes that could break older environments:
+-------------------------------------------
+
+* <get> has a new attribute authenticateOnRedirect that can be used to
+  prevent Ant from sending the configured credentials when following a
+  redirect. It is false by default, which means builds that rely on
+  credentials being used on the redirected URI may break.
+  Github Pull Request #173
+
 Other changes:
 --------------
 
@@ -16,11 +25,6 @@ Other changes:
 * <ftp> now supports FTPs.
   Github Pull Request #170
 
-* <get> has a new attribute authenticateOnRedirect that can be used to
-  prevent Ant from sending the configured credentials when following a
-  redirect. It is true by default for backwards compatibility reasons.
-  Github Pull Request #173
-
 Changes from Ant 1.10.11 TO Ant 1.10.12
 =======================================
 
diff --git a/manual/Tasks/get.html b/manual/Tasks/get.html
index b4c4e57..fe7deb4 100644
--- a/manual/Tasks/get.html
+++ b/manual/Tasks/get.html
@@ -95,7 +95,7 @@ the request is relayed to the proxy.</p>
     <td>authenticateOnRedirect</td>
     <td>Whether the credentials should also be sent to the new location when a redirect is followed.<br/>
     <em>since Ant 1.10.13</em></td>
-    <td>No; default is <q>true</q></td>
+    <td>No; default is <q>false</q></td>
   </tr>
   <tr>
     <td>maxtime</td>
diff --git a/src/main/org/apache/tools/ant/taskdefs/Get.java b/src/main/org/apache/tools/ant/taskdefs/Get.java
index 15f732f..03915cc 100644
--- a/src/main/org/apache/tools/ant/taskdefs/Get.java
+++ b/src/main/org/apache/tools/ant/taskdefs/Get.java
@@ -82,7 +82,7 @@ public class Get extends Task {
     private boolean ignoreErrors = false;
     private String uname = null;
     private String pword = null;
-    private boolean authenticateOnRedirect = true; // on by default for backward compatibility
+    private boolean authenticateOnRedirect = false;
     private long maxTime = 0;
     private int numberRetries = NUMBER_RETRIES;
     private boolean skipExisting = false;