You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Remilito <gi...@git.apache.org> on 2017/02/20 14:23:15 UTC
[GitHub] zeppelin pull request #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
GitHub user Remilito opened a pull request:
https://github.com/apache/zeppelin/pull/2042
[ZEPPELIN-1588]: bumping nvd3 to 1.8.5
### What is this PR for?
* bump nvd3 to 1.8.5 (and remove depecrated functions)
* display percentage in pie chart [solve ZEPPELIN-1891]
NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion.
### What type of PR is it?
Improvement
### Todos
* [ ] -
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-1588>
* <https://issues.apache.org/jira/browse/ZEPPELIN-1891>
### How should this be tested?
Visual testing of the builtin visualization.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2042
----
commit f0b3961547706f18b4b30fa36b93aeda7f24cc58
Author: Remilito <re...@gmail.com>
Date: 2017-02-20T13:26:45Z
[ZEPPELIN-1588]: bumping nvd3 to 1.8.5
* remove deprecated calls
* solve pie display pct
* better tooltip for scatterchart
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@Remilito I see. Thanks for explanation. It's okay, wasn't strong opinion. Looks good as is :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Looks nice! Better than before I think.
@Remilito The tooltip of scatter chart itself is good as you changed, but how about keeping these focusing marked on each axis?
<img src="https://cloud.githubusercontent.com/assets/10060731/23195636/01478120-f8f8-11e6-87b9-30469128c897.png" width="400px">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2042
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Merge into master and branch-0.7 if there are no more comments on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2042
FYI: https://issues.apache.org/jira/browse/ZEPPELIN-2230, comments appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Master branch is still being built by ASF's travis account and it's failing after this PR merged.
I think we need to merge a code that clear `bower_components` from the cache automatically when it is invalid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@soralee Thanks for digging it out! Since it's because of the cache in travis, someone who contributed to Zeppelin for the first time didn't went through this issue and saw green light. I think we need to guide contributors for a while to clear their cache as you did.
@1ambda Could you try like this to make sure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2042
thanks! I'd say the tooltip for pie is nicer in your change and perhaps tooltip for scatter the original one might be nicer.
Since this is a visible change I'll leave it open for others to comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@Remilito Just left a comment. (Also saw your PR \U0001f44d )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@1ambda Thanks for reporting it. Let me check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2042
I think bumping nvm3 version causes CI failure in profile 2, 3 and 6
- https://travis-ci.org/apache/zeppelin/builds/207845221
- https://travis-ci.org/apache/zeppelin/builds/208059749 (the most recent merged PR based on this PR)
```
[WARNING] warning Unmet peer dependency "eslint@>=3.8.1".
[ERROR] [{
[ERROR] "code": "ECONFLICT",
[ERROR] "name": "d3",
[ERROR] "picks": [
[ERROR] {
[ERROR] "endpoint": {
[ERROR] "name": "d3",
[ERROR] "source": "d3",
[ERROR] "target": "~3.3.13"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/build/apache/zeppelin/zeppelin-web/bower_components/d3",
[ERROR] "pkgMeta": {
[ERROR] "name": "d3",
[ERROR] "version": "3.3.13",
[ERROR] "main": "d3.js",
[ERROR] "scripts": [
[ERROR] "d3.js"
[ERROR] ],
[ERROR] "ignore": [
[ERROR] ".DS_Store",
[ERROR] ".git",
[ERROR] ".gitignore",
[ERROR] ".npmignore",
[ERROR] ".travis.yml",
[ERROR] "Makefile",
[ERROR] "bin",
[ERROR] "component.json",
[ERROR] "index-browserify.js",
[ERROR] "index.js",
[ERROR] "lib",
[ERROR] "node_modules",
[ERROR] "package.json",
[ERROR] "src",
[ERROR] "test"
[ERROR] ],
[ERROR] "homepage": "https://github.com/mbostock-bower/d3-bower",
[ERROR] "_release": "3.3.13",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v3.3.13",
[ERROR] "commit": "50df7cbc7f55d8b3a43304a7b029516255c10bdc"
[ERROR] },
[ERROR] "_source": "https://github.com/mbostock-bower/d3-bower.git",
[ERROR] "_target": "~3.3.13",
[ERROR] "_originalSource": "d3"
[ERROR] },
[ERROR] "dependencies": {},
[ERROR] "nrDependants": 1,
[ERROR] "dependants": [
[ERROR] {
[ERROR] "endpoint": {
[ERROR] "name": "nvd3",
[ERROR] "source": "nvd3",
[ERROR] "target": "~1.8.5"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/build/apache/zeppelin/zeppelin-web/bower_components/nvd3",
[ERROR] "pkgMeta": {
[ERROR] "name": "nvd3",
[ERROR] "version": "1.7.1",
[ERROR] "homepage": "http://www.nvd3.org",
[ERROR] "authors": [
[ERROR] "Bob Monteverde",
[ERROR] "Tyler Wolf",
[ERROR] "Robin Hu",
[ERROR] "Frank Shao",
[ERROR] "liquidpele"
[ERROR] ],
[ERROR] "description": "Re-usable charts and chart components for d3.",
[ERROR] "main": [
[ERROR] "build/nv.d3.js",
[ERROR] "build/nv.d3.css"
[ERROR] ],
[ERROR] "keywords": [
[ERROR] "d3",
[ERROR] "visualization",
[ERROR] "svg",
[ERROR] "charts"
[ERROR] ],
[ERROR] "license": "Apache License, v2.0",
[ERROR] "dependencies": {
[ERROR] "d3": "~3.3.13"
[ERROR] },
[ERROR] "ignore": [
[ERROR] "**/.*",
[ERROR] "node_modules",
[ERROR] "bower_components",
[ERROR] "test",
[ERROR] "src",
[ERROR] "examples",
[ERROR] "GruntFile.js",
[ERROR] "*.html",
[ERROR] "*.log",
[ERROR] "*.xml",
[ERROR] "*.json",
[ERROR] "*.md"
[ERROR] ],
[ERROR] "resolutions": {
[ERROR] "d3": "~3.3.13"
[ERROR] },
[ERROR] "devDependencies": {
[ERROR] "d3": "~3.3.13"
[ERROR] },
[ERROR] "_release": "1.7.1",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v1.7.1",
[ERROR] "commit": "679fe2ff96c194e442970cb9959ebccd79f6bd43"
[ERROR] },
[ERROR] "_source": "https://github.com/novus/nvd3.git",
[ERROR] "_target": "~1.7.1",
[ERROR] "_originalSource": "nvd3"
[ERROR] },
[ERROR] "dependencies": {
[ERROR] "d3": {
[ERROR] "endpoint": {
[ERROR] "name": "d3",
[ERROR] "source": "d3",
[ERROR] "target": "^3.4.4"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/.cache/bower/packages/bc5ff9f7cabfc286fa6975a1f3681c8f/3.5.17",
[ERROR] "pkgMeta": {
[ERROR] "name": "d3",
[ERROR] "description": "A JavaScript visualization library for HTML and SVG.",
[ERROR] "main": "d3.js",
[ERROR] "license": "BSD-3-Clause",
[ERROR] "ignore": [],
[ERROR] "homepage": "https://github.com/mbostock-bower/d3-bower",
[ERROR] "version": "3.5.17",
[ERROR] "_release": "3.5.17",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v3.5.17",
[ERROR] "commit": "abe0262a205c9f3755c3a757de4dfd1d49f34b24"
[ERROR] },
[ERROR] "_source": "https://github.com/mbostock-bower/d3-bower.git",
[ERROR] "_target": "^3.4.4"
[ERROR] },
[ERROR] "dependencies": {},
[ERROR] "nrDependants": 1
[ERROR] }
[ERROR] },
[ERROR] "nrDependants": 1
[ERROR] }
[ERROR] ]
[ERROR] },
[ERROR] {
[ERROR] "endpoint": {
[ERROR] "name": "d3",
[ERROR] "source": "d3",
[ERROR] "target": "^3.4.4"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/.cache/bower/packages/bc5ff9f7cabfc286fa6975a1f3681c8f/3.5.17",
[ERROR] "pkgMeta": {
[ERROR] "name": "d3",
[ERROR] "description": "A JavaScript visualization library for HTML and SVG.",
[ERROR] "main": "d3.js",
[ERROR] "license": "BSD-3-Clause",
[ERROR] "ignore": [],
[ERROR] "homepage": "https://github.com/mbostock-bower/d3-bower",
[ERROR] "version": "3.5.17",
[ERROR] "_release": "3.5.17",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v3.5.17",
[ERROR] "commit": "abe0262a205c9f3755c3a757de4dfd1d49f34b24"
[ERROR] },
[ERROR] "_source": "https://github.com/mbostock-bower/d3-bower.git",
[ERROR] "_target": "^3.4.4"
[ERROR] },
[ERROR] "dependencies": {},
[ERROR] "nrDependants": 1,
[ERROR] "dependants": [
[ERROR] {
[ERROR] "endpoint": {
[ERROR] "name": "nvd3",
[ERROR] "source": "nvd3",
[ERROR] "target": "~1.8.5"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/.cache/bower/packages/f3aa7be078a091021324bef143722262/1.8.5",
[ERROR] "pkgMeta": {
[ERROR] "name": "nvd3",
[ERROR] "homepage": "http://www.nvd3.org",
[ERROR] "authors": [
[ERROR] "Bob Monteverde",
[ERROR] "Tyler Wolf",
[ERROR] "Robin Hu",
[ERROR] "Frank Shao",
[ERROR] "liquidpele"
[ERROR] ],
[ERROR] "description": "Re-usable charts and chart components for d3.",
[ERROR] "main": [
[ERROR] "build/nv.d3.js",
[ERROR] "build/nv.d3.css"
[ERROR] ],
[ERROR] "keywords": [
[ERROR] "d3",
[ERROR] "visualization",
[ERROR] "svg",
[ERROR] "charts"
[ERROR] ],
[ERROR] "license": "Apache-2.0",
[ERROR] "dependencies": {
[ERROR] "d3": "^3.4.4"
[ERROR] },
[ERROR] "ignore": [
[ERROR] "**/.*",
[ERROR] "node_modules",
[ERROR] "bower_components",
[ERROR] "test",
[ERROR] "src",
[ERROR] "examples",
[ERROR] "GruntFile.js",
[ERROR] "*.html",
[ERROR] "*.log",
[ERROR] "*.xml",
[ERROR] "*.json",
[ERROR] "*.md"
[ERROR] ],
[ERROR] "version": "1.8.5",
[ERROR] "_release": "1.8.5",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v1.8.5",
[ERROR] "commit": "3fee7f9eec75b9e9234706cca01bf128607a41a6"
[ERROR] },
[ERROR] "_source": "https://github.com/novus/nvd3.git",
[ERROR] "_target": "~1.8.5"
[ERROR] },
[ERROR] "dependencies": {
[ERROR] "d3": {
[ERROR] "endpoint": {
[ERROR] "name": "d3",
[ERROR] "source": "d3",
[ERROR] "target": "^3.4.4"
[ERROR] },
[ERROR] "canonicalDir": "/home/travis/.cache/bower/packages/bc5ff9f7cabfc286fa6975a1f3681c8f/3.5.17",
[ERROR] "pkgMeta": {
[ERROR] "name": "d3",
[ERROR] "description": "A JavaScript visualization library for HTML and SVG.",
[ERROR] "main": "d3.js",
[ERROR] "license": "BSD-3-Clause",
[ERROR] "ignore": [],
[ERROR] "homepage": "https://github.com/mbostock-bower/d3-bower",
[ERROR] "version": "3.5.17",
[ERROR] "_release": "3.5.17",
[ERROR] "_resolution": {
[ERROR] "type": "version",
[ERROR] "tag": "v3.5.17",
[ERROR] "commit": "abe0262a205c9f3755c3a757de4dfd1d49f34b24"
[ERROR] },
[ERROR] "_source": "https://github.com/mbostock-bower/d3-bower.git",
[ERROR] "_target": "^3.4.4"
[ERROR] },
[ERROR] "dependencies": {},
[ERROR] "nrDependants": 1
[ERROR] }
[ERROR] },
[ERROR] "nrDependants": 1
[ERROR] }
[ERROR] ]
[ERROR] }
[ERROR] ],
[ERROR] "id": "ECONFLICT",
[ERROR] "level": "error",
[ERROR] "data": {},
[ERROR] "message": "Unable to find suitable version for d3",
[ERROR] "stacktrace": "d3: Unable to find suitable version for d3\n at createError (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/util/createError.js:4:15)\n at Manager._electSuitable (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/core/Manager.js:825:15)\n at /home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/core/Manager.js:609:25\n at _fulfilled (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/node_modules/q/q.js:834:54)\n at self.promiseDispatch.done (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/node_modules/q/q.js:863:30)\n at Promise.promise.promiseDispatch (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/node_modules/q/q.js:796:13)\n at /home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/node_modules/q/q.js:556:49\n at runSingle (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/
bower/lib/node_modules/q/q.js:137:13)\n at flush (/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/bower/lib/node_modules/q/q.js:125:13)\n at _combinedTickCallback (internal/process/next_tick.js:67:7)\n at process._tickCallback (internal/process/next_tick.js:98:9)"
[ERROR] }]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@Remilito I just closed this PR and tying to find your JIRA id. Is your ID "Remy Gayet"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Tested and it works well. Definitely better than before \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@Leemoonsoo Thanks for the quick response! Let me create a hotfix PR then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@AhyoungRyu : I have just checked, those "axis-boxes" seemed to have disappeared from nvd3 after 1.7.1. However the new tooltip provides both x and y values. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2042
cc @1ambda @AhyoungRyu :smile:
In my case, I fixed same error with click `Delete all repository cache` as explained in [Travis document](https://docs.travis-ci.com/user/caching/#Clearing-Caches)
I guess this error is occurred by cache of Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2042
@Leemoonsoo For a stopgap, we can remove [this line](https://github.com/apache/zeppelin/blob/master/.travis.yml#L28) and merge to master. And after we see green light, let's put `zeppelin-web/bower_components` back to travis file. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2042
Sounds like a plan!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---