[jira] [Commented] (FLINK-9165) Improve CassandraSinkBase to send Collections

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436318#comment-16436318 ] 

ASF GitHub Bot commented on FLINK-9165:
---------------------------------------

GitHub user Bekreth opened a pull request:

    https://github.com/apache/flink/pull/5844

    [FLINK-9165] [DataSink] Upgrading CassandraSinkBase to submit collections

    *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
    
    ## Contribution Checklist
    
      - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
      
      - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
    
      - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
      
      - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
    
      - Each pull request should address only one issue, not mix up code from multiple issues.
      
      - Each commit in the pull request has a meaningful commit message (including the JIRA id)
    
      - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
    
    
    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    Initial issue : [https://issues.apache.org/jira/browse/FLINK-9165]
    Currently the CassandraSinkBase can only handle single objects.  This PR aims to add the ability to submit collections.
    
    
    ## Brief change log
    
    *Overloaded `send()` method in the CassandraSinkBase to handle collections.  Cascaded this change into all classes extending the CassandraSinkBase.
    
    
    ## Verifying this change
    
    Verified this tooling in local projects.  Testing will be including following discussion on implementation.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? yes
      - If yes, how is the feature documented? This features functionality is trivial and in line with current documentation.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Bekreth/flink sinkCollections

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5844
    
----
commit 46a94824d64eef69015f586ce0319a603b2f9bb3
Author: chugh13 <ch...@...>
Date:   2018-04-12T20:29:07Z

    Added in functionality to AbstractCassandraTupleSink and all its children to submit collections of tuples.

commit 2779b64e615f836f8fc0d6deacf14201bc55c183
Author: chugh13 <ch...@...>
Date:   2018-04-12T20:30:31Z

    Merge branch 'master' into sinkCollections

----


> Improve CassandraSinkBase to send Collections
> ---------------------------------------------
>
>                 Key: FLINK-9165
>                 URL: https://issues.apache.org/jira/browse/FLINK-9165
>             Project: Flink
>          Issue Type: Improvement
>          Components: Cassandra Connector
>    Affects Versions: 1.4.2
>            Reporter: Christopher Hughes
>            Priority: Minor
>              Labels: easyfix, feature
>
> The CassandraSinkBase can currently only handle individual objects.  I propose overloading the `send(IN value)` method to include `send(Collection<IN> value)`. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)