You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2026/06/22 11:47:22 UTC

[PR] Refactor concat [datafusion]

Jefffrey opened a new pull request, #23079:
URL: https://github.com/apache/datafusion/pull/23079

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Simplify `concat`/`concat_ws` simplification path & support binary in `concat` simplification [datafusion]

Posted by "andygrove (via GitHub) via github" <gi...@datafusion.apache.org>.
andygrove commented on PR #23079:
URL: https://github.com/apache/datafusion/pull/23079#issuecomment-6833952323

   Follow-up to the heads-up above: the `datafusion-spark` crate now lives in https://github.com/apache/datafusion-spark, and that repo is ready to accept PRs.
   
   If this PR changes `datafusion-spark` files, please open a new PR with those changes against apache/datafusion-spark. Before opening it, please read the [contributing guide](https://github.com/apache/datafusion-spark/blob/main/CONTRIBUTING.md). Any changes to other DataFusion crates stay in this PR. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Simplify `concat`/`concat_ws` simplification path & support binary in `concat` simplification [datafusion]

Posted by "jayzhan211 (via GitHub) via github" <gi...@datafusion.apache.org>.
jayzhan211 commented on PR #23079:
URL: https://github.com/apache/datafusion/pull/23079#issuecomment-6579057168

   @Jefffrey This looks like an old PR that was missed in review. I can take a look if we can get the CI green again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Simplify `concat`/`concat_ws` simplification path & support binary in `concat` simplification [datafusion]

Posted by "andygrove (via GitHub) via github" <gi...@datafusion.apache.org>.
andygrove commented on PR #23079:
URL: https://github.com/apache/datafusion/pull/23079#issuecomment-6803122913

   Heads-up: as discussed in https://github.com/apache/datafusion/issues/27103, we plan to move the `datafusion-spark` crate, including its sqllogictest files and git history, to the new https://github.com/apache/datafusion-spark repo in the next day or two. After that, changes to `datafusion-spark` will go to the new repo.
   
   This PR changes `datafusion-spark` files. If it hasn't merged before the move, please open a new PR with those changes against apache/datafusion-spark (GitHub can't transfer PRs between repos). Any changes to other DataFusion crates stay here. We'll post instructions for porting open PRs in #27103 once the code is in place.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Simplify `concat`/`concat_ws` simplification path & support binary in `concat` simplification [datafusion]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23079:
URL: https://github.com/apache/datafusion/pull/23079#issuecomment-5087928283

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/23079?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `83.90805%` with `28 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 80.64%. Comparing base ([`e8a65f2`](https://app.codecov.io/gh/apache/datafusion/commit/e8a65f2d6f24afa75192fc63aca38011ede88800?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b28d7c4`](https://app.codecov.io/gh/apache/datafusion/commit/b28d7c4ab20e213847dcd4d49b896c6cf392089d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/23079?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [datafusion/functions/src/string/concat\_ws.rs](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&filepath=datafusion%2Ffunctions%2Fsrc%2Fstring%2Fconcat_ws.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMvc3JjL3N0cmluZy9jb25jYXRfd3MucnM=) | 82.47% | [14 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [datafusion/functions/src/string/concat.rs](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&filepath=datafusion%2Ffunctions%2Fsrc%2Fstring%2Fconcat.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMvc3JjL3N0cmluZy9jb25jYXQucnM=) | 85.29% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [datafusion/spark/src/function/string/concat.rs](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&filepath=datafusion%2Fspark%2Fsrc%2Ffunction%2Fstring%2Fconcat.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9zcGFyay9zcmMvZnVuY3Rpb24vc3RyaW5nL2NvbmNhdC5ycw==) | 88.88% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23079?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main   #23079      +/-   ##
   ==========================================
   - Coverage   80.66%   80.64%   -0.03%     
   ==========================================
     Files        1095     1095              
     Lines      372294   372199      -95     
     Branches   372294   372199      -95     
   ==========================================
   - Hits       300324   300157     -167     
   - Misses      54055    54121      +66     
   - Partials    17915    17921       +6     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/23079?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Simplify `concat`/`concat_ws` simplification path & support binary in `concat` simplification [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #23079:
URL: https://github.com/apache/datafusion/pull/23079#issuecomment-4768543909

   Recommend reviewing commit by commit as each commit breaks down cleanly as a unit of work, and has some explanatory commentary along the way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org