You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by an...@apache.org on 2020/06/02 07:59:09 UTC
[mynewt-nimble] branch master updated (060092a -> f8a3966)
This is an automated email from the ASF dual-hosted git repository.
andk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git.
from 060092a nimble/hs: Fix flow control
new 1a4e561 nimble/ll: Fix typo
new f8a3966 nimble/ll: Fix controller to host flow
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
nimble/controller/src/ble_ll_conn.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[mynewt-nimble] 01/02: nimble/ll: Fix typo
Posted by an...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
commit 1a4e56196dc4570959a26ba262fe8b0e7319389e
Author: Andrzej Kaczmarek <an...@codecoup.pl>
AuthorDate: Thu May 28 12:17:01 2020 +0200
nimble/ll: Fix typo
That is actually few typos in a row ;)
---
nimble/controller/src/ble_ll_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nimble/controller/src/ble_ll_conn.c b/nimble/controller/src/ble_ll_conn.c
index 8799ff2..a157732 100644
--- a/nimble/controller/src/ble_ll_conn.c
+++ b/nimble/controller/src/ble_ll_conn.c
@@ -2021,7 +2021,7 @@ ble_ll_conn_end(struct ble_ll_conn_sm *connsm, uint8_t ble_err)
/* Remove from the active connection list */
SLIST_REMOVE(&g_ble_ll_conn_active_list, connsm, ble_ll_conn_sm, act_sle);
-#if MYNEWT_VAL(BLE_LL_CFG_FEAT_HOST_TO_CTRL_FLOW_CONTROL)
+#if MYNEWT_VAL(BLE_LL_CFG_FEAT_CTRL_TO_HOST_FLOW_CONTROL)
ble_ll_conn_cth_flow_free_credit(connsm, connsm->cth_flow_pending);
#endif
[mynewt-nimble] 02/02: nimble/ll: Fix controller to host flow
Posted by an...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-nimble.git
commit f8a396662d0157f268dc0fec4597352f853c56de
Author: Andrzej Kaczmarek <an...@codecoup.pl>
AuthorDate: Mon May 25 17:05:06 2020 +0200
nimble/ll: Fix controller to host flow
We should not attempt to allocate credit for data PDU in case of CRC
error because such PDU will not be handed over to LL thus we will never
get that credit back.
---
nimble/controller/src/ble_ll_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nimble/controller/src/ble_ll_conn.c b/nimble/controller/src/ble_ll_conn.c
index a157732..cb80250 100644
--- a/nimble/controller/src/ble_ll_conn.c
+++ b/nimble/controller/src/ble_ll_conn.c
@@ -3808,7 +3808,7 @@ ble_ll_conn_rx_isr_end(uint8_t *rxbuf, struct ble_mbuf_hdr *rxhdr)
* available, we don't need to allocate buffer for this packet so LL will
* nak it.
*/
- if (ble_ll_conn_cth_flow_is_enabled() &&
+ if (alloc_rxpdu && ble_ll_conn_cth_flow_is_enabled() &&
BLE_LL_LLID_IS_DATA(hdr_byte) && (rx_pyld_len > 0)) {
if (ble_ll_conn_cth_flow_alloc_credit(connsm)) {
rxhdr->rxinfo.flags |= BLE_MBUF_HDR_F_CONN_CREDIT;