[jira] Updated: (SHINDIG-937) Legacy _IG_Prefs.getString/Array methods should return unescaped prefs

["John Hjelmstad (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Hjelmstad updated SHINDIG-937:
-----------------------------------

    Attachment: SHINDIG-937.patch

Proposed patch is attached. The patch does create a situation in which the gadgets.Prefs instance's getString and getArray methods will be overridden if a "new _IG_Prefs" is created. This situation should be essentially nonexistent, however. Reviews most welcome... I may have missed some other side effect.

> Legacy _IG_Prefs.getString/Array methods should return unescaped prefs
> ----------------------------------------------------------------------
>
>                 Key: SHINDIG-937
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-937
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: trunk
>            Reporter: John Hjelmstad
>             Fix For: trunk
>
>         Attachments: SHINDIG-937.patch
>
>
> The gadgets.Prefs.prototype.getString/Array methods changed the semantics of the equivalent methods in _IG_Prefs, by escaping data returned from them. This was done for sensible security reasons, but unfortunately also breaks many legacy gadgets.
> in order to maintain functional backward compatibility, I submit the _IG_Prefs versions should return unescaped data rather than causing random breakages.
> To be clear, this change would apply *only* to the prefs retrieved via JS, not to __UP substitution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.