You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/05 22:48:20 UTC

[GitHub] [kafka] mjsax opened a new pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

mjsax opened a new pull request #8819:
URL: https://github.com/apache/kafka/pull/8819


   Call for review @guozhangwang @vvcephei 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639921919


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax merged pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #8819:
URL: https://github.com/apache/kafka/pull/8819


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei commented on a change in pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

Posted by GitBox <gi...@apache.org>.
vvcephei commented on a change in pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#discussion_r436211217



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -86,7 +87,7 @@
     private boolean rebalanceInProgress = false;  // if we are in the middle of a rebalance, it is not safe to commit
 
     // includes assigned & initialized tasks and unassigned tasks we locked temporarily during rebalance
-    private Set<TaskId> lockedTaskDirectories = new HashSet<>();
+    private final Set<TaskId> lockedTaskDirectories = new HashSet<>();

Review comment:
       Jinx! https://github.com/apache/kafka/pull/8818#discussion_r436193832




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639972125


   Merged to `trunk` and cherry-picked to `2.6`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #8819: MINOR: improve code encapsulation between StreamThread and TaskManager

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8819:
URL: https://github.com/apache/kafka/pull/8819#issuecomment-639921872


   Java 8 and Java 11 failed with env errors. Java 14 passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org