You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by zizhong <gi...@git.apache.org> on 2017/02/16 18:17:27 UTC
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/1457
fix TS-4195: crash when stop trafficserver
Because of `psiginfo`, `psignal` and `exit`, which call `malloc` and `free` inside `proxy_signal_handler`. ATS will crash from time to time when stop.
> A signal handler can be called at any time, including during times when another call to malloc is in progress. If this happens, one of two things will occur:
>
> Your process will deadlock inside the signal handler, because malloc will be unable to acquire the heap lock.
> Your process will corrupt its heap, because malloc does acquire the lock (or doesn't think it needs it), then proceeds to render the heap inconsistent, leading to a later crash.
From [here](http://stackoverflow.com/questions/3366307/why-is-malloc-not-async-signal-safe)
Tested with a script repeating starting and stopping ATS on RHEL 6.6, the current master crashes after about 2~10 times. This patch doesn't crash after 6k+ tries.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zizhong/trafficserver TS-4195
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1457.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1457
----
commit 8a9365aebd0eaa3a9fd451703996060c869fa7f5
Author: Zizhong Zhang <zi...@zizhang-ld2.linkedin.biz>
Date: 2017-02-16T18:03:15Z
fix TS-4195: double free when stop trafficserver
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@jpeach @zwoop , already
> tested with --enable-asan and didn't find any issue.
and posted it in this thread. But looks like my message got buried with this huge amount of build logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Is it still possible to use leak checkers that reconcile at exit after this fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/132/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1457#discussion_r103324828
--- Diff: proxy/Main.cc ---
@@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void *ctx)
shutdown_event_system = true;
sleep(1);
- ::exit(signo);
--- End diff --
This is going to cause an issue with leak detection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/141/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Sorry for the build failed. It's because missed a piece when merging the code. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1576/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1471/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1567/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1470/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1457
With some additional effort, we can fix this reliably. The traditional way to do this is for the signal handler to write a byte to a pipe, which will wake up an event handler to do an ordered shutdown. On linux, you could also use signalfd. Something like this should be the goal here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I checked the config.log and found the problem. I didn't have `asan` installed. However, the error message here was quite misleading.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Hmm, this line of code is not added by this patch. I would say this is an already existed issue.
I can work on fixing this. Is there a way to know all these places which not checking return value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/143/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@jpeach , I haven't tested it yet.
I would like to try it.
Then I configured it with `--enable-asan`, but got
```
checking whether compiling and linking against OpenSSL works...no
configure: error: failed to find OpenSSL.
```
But without `--enable-asan`, my configuration works and clearly, I have openssl installed.
Any ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Tested with `--enable-asan` and didn't find any issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , thanks! Rebased and pushed again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I've tested this with leak detection, and it seems to still work (it reports quite a few leaks). So I'm going to land this :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/9/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Failed at
```
P_IOBuffer.h(697): error #1011: missing return statement at end of non-void function "IOBufferReader::operator[]"
}
^
```
I can try to fix it with another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Did we address @jpeach concern re: memory leak debugging? Also, probably would be a good idea if @bryancall chimed in here, since he did a lot of the work around making ASAN etc. function properly on exit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
I've reverted this, as per @bryancall recommendation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1472/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Also, I'm gonna mark this for v7.1.0, because I've experienced these crashers myself, and they are super annoying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1461/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zizhong No need to apologize, this is exactly why we have a CI / build system. :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/10/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/11/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , @bryancall, Hey, what is the next step about this? We can't let ATS crashes this way. We also want our leak detection tools to work fine. Why is `exit` mandatory in our signal handler? Could you share some insight with me, so that I can work on a different fix accordingly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/142/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Yeh, this failed because the Intel installation was not correct on one of the VMs. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1457#discussion_r103575599
--- Diff: proxy/Main.cc ---
@@ -460,7 +460,7 @@ proxy_signal_handler(int signo, siginfo_t *info, void *ctx)
shutdown_event_system = true;
sleep(1);
- ::exit(signo);
--- End diff --
I couldn't understand why this change can cause an issue with leak detection.I read your original ticket about this line changing from `_exit` to `exit`. The reason you made that change was to fix some crashes on fedora instead of fixing leak detection issues. However,
it's never okay to call `exit` in a signal handler. `exit()` is not an Async-signal-safe function, which can refer to [this man page](http://man7.org/linux/man-pages/man7/signal.7.html). Hence, we got lots of crashes when stopping or restarting ATS.
Besides, @zwoop tested this patch didn't make any behavior change of leak detection tools.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by jaaju <gi...@git.apache.org>.
Github user jaaju commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zizhong you need to call `exit` for normal process termination in case of SIGTERM so ASAN leak detection report is available. But since you can not call `exit` from the signal handler, what @jpeach suggests is to merely take note of the delivered signal and call `exit` later when normal process execution resumes. The pipe is a mechanism to wake up the code that calls `exit`, and you can write to the pipe calling only async-signal-safe routines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Thanks @jpeach . I do not fully understand what you suggested. Could you explain a bit more, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1578/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1457
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1577/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Ah, that fails because you don't have the fixes I made on master. All you have to do is rebase your branch with current master, and push again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@bcall Should we back this out? Fwiw, I don't see a difference in leak detection with or without this, they both fail badly on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
This introduced a new Coverity issues:
```
*** CID 1371483: Error handling issues (CHECKED_RETURN)
/lib/ts/signals.cc: 173 in signal_format_siginfo(int, siginfo_t *, const char *)()
167 #if HAVE_STRSIGNAL
168 snprintf(buf, sizeof(buf), "%s: received signal %d (%s)\n", msg, signo, strsignal(signo));
169 #else
170 snprintf(buf, sizeof(buf), "%s: received signal %d\n", msg, signo);
171 #endif
172
CID 1371483: Error handling issues (CHECKED_RETURN)
Calling "write" without checking return value (as is done elsewhere 29 out of 33 times).
173 write(STDERR_FILENO, buf, strlen(buf));
174 }
175
176 void
177 signal_crash_handler(int signo, siginfo_t *, void *)
178 {
```
Assuming we don't revert this change, we need to fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver
Posted by zizhong <gi...@git.apache.org>.
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zwoop , in https://ci.trafficserver.apache.org/job/icc-github/9/
```
checking whether the C compiler works... no
configure: error: in `/var/jenkins/workspace/icc-github/src':
configure: error: C compiler cannot create executables
```
It seem sto be failed in configuration phase. Can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---