[GitHub] [iceberg-rust] liurenjie1024 commented on a diff in pull request #40: feat: Introduce conversion between iceberg schema and avro schema

["liurenjie1024 (via GitHub)" <gi...@apache.org>]

liurenjie1024 commented on code in PR #40:
URL: https://github.com/apache/iceberg-rust/pull/40#discussion_r1308139355


##########
crates/iceberg/src/lib.rs:
##########
@@ -18,6 +18,7 @@
 //! Native Rust implementation of Apache Iceberg
 
 #![deny(missing_docs)]
+#![allow(dead_code)]

Review Comment:
   This is to avoid clippy warning.



##########
crates/iceberg/src/lib.rs:
##########
@@ -27,4 +28,5 @@ pub use error::Error;
 pub use error::ErrorKind;
 pub use error::Result;
 
+mod avro;

Review Comment:
   Currently no.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org