You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2015/11/20 09:42:41 UTC
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-couch/pull/128
Explicitly authorize test requests
Create admin user and use its credentials for requests
Use http requests to create and delete test dbs to avoid potential db
name munging issues downstream
COUCHDB-2897
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2897-couchdb_mrview_cors_tests-explicit-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit 988b6fc642dd058159c4af56b09afef6c6754afc
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-20T08:39:24Z
Explicitly authorize test requests
Create admin user and use its credentials for requests
Use http requests to create and delete test dbs to avoid potential db
name munging issues downstream
COUCHDB-2897
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45447657
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
btw, is there reason to switch from Erlang to HTTP API for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-158479306
Also, I'm wondering what's going on with travis. It's been over 12 hours that the build has been pending...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45497613
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Again, the principle of YAGNI was what prevented me from making that change for the eventual possibility. However, I'm fine to add it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45447575
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
DELETE /db may eventually return HTTP 202 response.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45497082
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
In the spirit of YAGNI, I would be inclined to assume 200 for successful DELETE response until otherwise necessary. Also, the docs don't mention 202:
http://docs.couchdb.org/en/latest/api/database/common.html?highlight=delete#delete--db
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45498132
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
Documentation is not updated for 2.0 actually, so YAGNI source is in erlang sources for now (:
Ok with fabric to HTTP replacement, though it strange that we do this with Erlang, not JS. Need to revisit this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45448036
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Better to make a switch for httpd/chttpd here as well since you may eventually try to test backdoor interface using chttpd port. Someday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45498307
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Thanks! (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45542179
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Ah, this makes perfect sense now; thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-158330279
LGFM, except on moment, but you seems start to repeat yourself. We have quite a lot of tests where Admin Party implicitly assumed.
May be it worth to make a single change for test_util to setup cluster without AP and fix all at once?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45514605
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Basically, I think:
```
db_url(DbName) when is_binary(DbName) -> db_url(binary_to_list(DbName));
db_url(DbName) when is_list(DbName) -> host_url(cluster) ++ "/" ++ DbName.
host_url(Interface) -> "http://" ++ bind_address(Interface) ++ ":" ++ port(Interface).
bind_address(cluster) -> config:get("chttpd", "bind_address", "127.0.0.1");
bind_address(backdoor) -> config:get("httpd", "bind_address", "127.0.0.1").
port(cluster) -> integer_to_list(mochiweb_socket_server:get(chttpd, port));
port(backdoor) -> integer_to_list(mochiweb_socket_server:get(couch_httpd, port)).
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-159397671
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-158479170
@kxepal, I hear what you are saying about the Admin Party being assumed for many tests. However, at this point I have not taken a full inventory, and am only focusing on the suites which are failing downstream for various reasons. So far, the ones I've been able to fix by adding explicit authentication are just this one and https://github.com/apache/couchdb-chttpd/pull/91. I'm guessing that the other implicit Admin Party tests may not be doing things (like creating/deleting DBs) which would cause breakage downstream, where an Admin Party is less permissive than in the CouchDB case.
So, in short, I don't think there will be many more PRs such as this. The remaining tests that are failing downstream have much bigger problems, and are likely "unfixable" based on what they are trying to test. I think we'll just have to disable them in downstream builds and move on :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-158480315
@jaydoane ): ok
Travis pending is seems because of ASF tasks queue overflow again. This can last for a long time, suddenly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45514103
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
+ ok.
+host_url(PortType) ->
+ Addr = config:get("httpd", "bind_address", "127.0.0.1"),
--- End diff --
Actually, I think the only way the host_url depends on PortType (which can be either 'clustered' or 'backdoor') is expressed via the port/1 function. I'm not sure how you would improve or generalize this.
Or did you mean db_url, which is only valid for clustered PortType? That could be generalized by adding a PortType parameter, but I didn't bother since it's only being used in the clustered cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/128#issuecomment-158592475
@kxepal, I believe the changes we discussed have been included in latest push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45497488
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
The reason for the switch from fabric db creation to the HTTP API is because in some downstream cases (specifically to support multiple tenants in one cluster), the DB name gets munged in a way to indicate to which user it belongs. This happens transparently through the HTTP API, but fabric knows nothing about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Explicitly authorize test requests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/128#discussion_r45514254
--- Diff: test/couchdb_mrview_cors_tests.erl ---
@@ -86,14 +95,25 @@ create_db(backdoor, DbName) ->
{ok, Db} = couch_db:create(DbName, [?ADMIN_CTX]),
couch_db:close(Db);
create_db(clustered, DbName) ->
- ok = fabric:create_db(DbName, [?ADMIN_CTX]).
+ {ok, Status, _, _} = test_request:put(db_url(DbName), [?AUTH], ""),
+ true = lists:member(Status, [201, 202]),
+ ok.
delete_db(backdoor, DbName) ->
couch_server:delete(DbName, [?ADMIN_CTX]);
delete_db(clustered, DbName) ->
- ok = fabric:delete_db(DbName, [?ADMIN_CTX]).
+ {ok, 200, _, _} = test_request:delete(db_url(DbName), [?AUTH]),
--- End diff --
Ah, good to know about Docs - thanks. I'll go ahead and make the change, as it's pretty minor and will indeed make the test more robust.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---